Use artifact name when copying a binary or a library in the dist task #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntrinquier
commented
May 18, 2023
| @@ -73,12 +73,7 @@ def execute(self) -> None: | |||
| output_file.parent.mkdir(parents=True, exist_ok=True) | |||
| with wopen_archive(output_file, archive_type) as archive: | |||
| for resource in self.resources.get(): | |||
| if resource.options.arcname is not None: | |||
| arcname = resource.options.arcname | |||
| elif isinstance(resource, BinaryArtifact): | |||
There was a problem hiding this comment.
this is where the bug was: at this point, resource may no longer be a BinaryArtifact, it is necessarily a ConfiguredResource (as the type of the property attests), which has no overlap with BinaryArtifact
added 3 commits
May 18, 2023 08:46
ntrinquier
commented
May 18, 2023
| task_options = dependencies_map[next(iter(dependencies_set.partitions()[task]))] | ||
| options = IndividualDistOptions(**vars(task_options)) | ||
|
|
||
| if options.arcname is None and isinstance(resource, (BinaryArtifact, LibraryArtifact)): |
There was a problem hiding this comment.
the solution is to move the logic where we construct the ConfiguredResources, to set the arcname in the options there
note that LibraryArtifacts now also get their arcname changed, which is hopefully not controversial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.