Update dependencies before attempting to package with helm #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip-checks: true
ntrinquier
reviewed
May 18, 2023
| @@ -23,7 +23,7 @@ def helm_package( | |||
| raise ValueError("output_file and output_directory cannot both be set") | |||
|
|
|||
| with contextlib.ExitStack() as exit_stack: | |||
| command = ["helm", "package", str(chart_path)] | |||
| command = ["helm", "package", str(chart_path), "--dependency-update"] | |||
There was a problem hiding this comment.
@callumPearce can we make this configurable with a keyword argument dependency_update in helm_package? (for which defaulting to True is reasonable IMO)
Suggested change
| command = ["helm", "package", str(chart_path), "--dependency-update"] | |
| command = ["helm", "package", str(chart_path)] | |
| if dependency_update: | |
| command.append("--dependency-update") |
ntrinquier
requested changes
May 19, 2023
| @@ -16,6 +16,7 @@ def helm_package( | |||
| output_directory: Path | None = None, | |||
| app_version: str | None = None, | |||
| version: str | None = None, | |||
| update_chart_dependencies: bool = True | |||
There was a problem hiding this comment.
Suggested change
| update_chart_dependencies: bool = True | |
| update_chart_dependencies: bool = True, |
ntrinquier
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.