-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc/improve exception handling #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the pretty_errors package. https://github.com/onelivesleft/PrettyErrors This pretty printing can can be disabled by adding PYTHON_PRETTY_ERRORS=0 to your environment.
TheMightyFid
added
type: documentation
Improvements or additions to documentation
type: enhancement
New feature or request
labels
May 24, 2023
skip-checks: true
…nto cc/improve-exception-handling
@cdbrkfxrpt + @NiklasRosenstein, this should be ready for review. It is best used in conjunction with #32 |
cdbrkfxrpt
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm - cc @NiklasRosenstein @ntrinquier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: documentation
Improvements or additions to documentation
type: enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic MR to improve readability of Kraken errors and add links for support etc, through the addition of the pretty-errors package.
These errors can be disabled (and the normal ones restored) by defining the variable
PYTHON_PRETTY_ERRORS=0
to your environment.https://github.com/onelivesleft/PrettyErrors (MIT Licence)
Example below: