Disable the nightly formatter by default #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I saw the default nightly formatting feature merge earlier and I realised that I was kind of hosed. Why? I don't use Rustup, and this feature relies on Rustup, so my kraken fmt doesn't work anymore. I'm also a bit concerned that the behaviour as implemented forces every dev team onto nightly Rust, which I don't think we should be encouraging without careful thought and some tooling. I'd therefore like us to take a quick step back by making it be an opt-in and not an opt-out feature so as to give more time for the above attributes to be addressed. Sound good?
skip-checks: true
|
I believe the glitch is here: where it fails if nightly is not the toolchain in use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I saw the default nightly formatting feature merge earlier and I realised that I was kind of hosed. Why? I don't use Rustup, and this feature relies on Rustup, so my kraken fmt doesn't work anymore.
I'm also a bit concerned that the behaviour as implemented default moves every dev team onto nightly Rust, which I don't think we should be encouraging without careful thought and some tooling.
I'd therefore like us to take a quick step back by making it be an opt-in and not an opt-out feature so as to give more time for the above attributes to be addressed. Sound good?
It feels like the correct default behaviour would be to add a 'nightly' flag that runs all commands with nightly rust, rather than just fmt, and so one can opt a project into nightly rust and not just the formatter.