nr/base object #44
Merged
nr/base object #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method and deprecated `Project.subproject()` overloads.
…ad-only property
…enObject` class kraken-core/: deprecation: Deprecate `Project.path` and `Project.resolve_tasks()`
…bal scope, as otherwise we run into an issue with Dill deserialization where the type of `Address.elements` items is not actually the `Address.Element` type that we can access at runtime. (See uqfoundation/dill#600).
…`Address` keys instead of strings
skip-checks: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project.children()method and deprecatedProject.subproject()overloads.Addressable.addressinto a read-only propertyProject.subproject()inContext.get_project()Projecta subclass of the newKrakenObjectclassTask.captureAddress.Elementclass definition to the global scope, as otherwise we run into an issue with Dill deserialization where the type ofAddress.elementsitems is not actually theAddress.Elementtype that we can access at runtime. (See Dill unpickles into a new type for classes defined inside another class uqfoundation/dill#600).TaskGraphimplementation now storesAddresskeys instead of strings