pytest coverage #48
Merged
pytest coverage #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpoumarede
force-pushed
the
bp/pytest-coverage
branch
14 times, most recently
from
ca66719
to
a7f7e2b
Compare
| command += [ | ||
| "--cov-report", | ||
| f"{self.coverage.get()}:{str(self.project.build_directory / coverage_file)}", | ||
| f"--cov={str(self.project.directory / tests_dir)}", |
There was a problem hiding this comment.
The --cov option needs to point to the source directory
There was a problem hiding this comment.
You are right, I will change that
bpoumarede
force-pushed
the
bp/pytest-coverage
branch
7 times, most recently
from
ce2660e
to
4cb2751
Compare
bpoumarede
force-pushed
the
bp/pytest-coverage
branch
2 times, most recently
from
9998f72
to
009ad3b
Compare
bpoumarede
force-pushed
the
bp/pytest-coverage
branch
2 times, most recently
from
4d931b8
to
dba3397
Compare
bpoumarede
force-pushed
the
bp/pytest-coverage
branch
from
dba3397
to
335e313
Compare
NiklasRosenstein
approved these changes
Jul 13, 2023
antoinebrl
reviewed
Aug 4, 2023
Comment on lines
+61
to
+65
| command += [ | ||
| "--cov-report", | ||
| f"{self.coverage.get().get_format()}:{str(self.project.build_directory / coverage_file)}", | ||
| f"--cov={str(self.project.directory / self.settings.source_directory)}", | ||
| ] |
There was a problem hiding this comment.
Should there be a check to see if pytest-cov is installed before adding these parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.