Bump Cargo.toml version before building #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daladim
force-pushed
the
bump_cargo_version_before_build
branch
2 times, most recently
from
e12fde8
to
62bf890
Compare
ntrinquier
reviewed
Jun 23, 2023
Before this commit, Cargo.toml was only bumped before _publishing_, but the binary would already have been built and cached,
and any use of e.g. `env!("CARGO_PKG_VERSION")` would return unexpected values
daladim
force-pushed
the
bump_cargo_version_before_build
branch
from
d9eca6f
to
def5b80
Compare
ntrinquier
reviewed
Jun 23, 2023
daladim
force-pushed
the
bump_cargo_version_before_build
branch
from
1ecccae
to
1f12823
Compare
daladim
force-pushed
the
bump_cargo_version_before_build
branch
from
1f12823
to
34eae3d
Compare
skip-checks: true
ntrinquier
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, Cargo.toml was only bumped before publishing, but the binary would already have been built and cached, and any use of e.g.
env!("CARGO_PKG_VERSION")would return unexpected values