Deprecate Project.do() and several bug fixes
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which deprecated `Project.do()`
…yword argument and optimize `Address.concat()` and `Address.append()` to short-circuit return value if `Address.CURRENT` is passed to them.
…sed, which is intended to resolve only the default tasks in the current project and its subprojects. Before this fix, the method would return _all_ tasks of the current project instead, because the address `.` would be treated like a single-element address, such as `lint`, which gets turned into `:**:.` (or `:**:lint`).
…t can be used in BuildDSL build scripts to define custom tasks. It creates an instance of an `InlineTask`, which also allows adding properties dynamically.
…dule and remove backwards compatibility for `mypy_subtest()` function name.
…ommand by appending it to the arguments, allowing to use `krakenw query` subcommands from subdirectories.
NiklasRosenstein
changed the title
Project.do() and several bug fixes
NiklasRosenstein
changed the title
Project.do() and several bug fixesProject.do() and several bug fixes
skip-checks: true
…r, allowing to assign property values to tasks using assignments in addition to `set()`. Assigning `None` to it will set it to `None` for optional properties, and clear it for non-optional properties.
…cripts to avoid searching up higher for the project root directory.
…project directory.
skip-checks: true
…o-save` option and to never save the build context to disk after the command.
skip-checks: true
…iguration, such as commit signing which could prompt the user running the tests to enter their GPG passphrase, blocking the test.
…o align with the rest of the task factory functions (e.g. automatically take the current project and build system).
…n `kraken.std.python.tasks` explicit and change `List` properties to contain a `Sequence`
skip-checks: true
…ctory because the version of `krakenw` that we use in CI does not yet support the `# ::krakenw-root` directive
…this only works in our current version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project.task()overload to create tasks, which deprecatedProject.do()Project.do()in favor ofProject.task()GroupTasktoProject.task(group)Address.normalize(keep_container)keyword argument and optimizeAddress.concat()andAddress.append()to short-circuit return value ifAddress.CURRENTis passed to them.Context.resolve_tasks()whenNoneis passed, which is intended to resolve only the default tasks in the current project and its subprojects. Before this fix, the method would return all tasks of the current project instead, because the address.would be treated like a single-element address, such aslint, which gets turned into:**:.(or:**:lint).Project.task(name, closure)overload that can be used in BuildDSL build scripts to define custom tasks. It creates an instance of anInlineTask, which also allows adding properties dynamically.kraken.buildscript to project root which handles docs buildingmypy_stubtest_taskmodule and remove backwards compatibility formypy_subtest()function name.-poption to thekrakencommand by appending it to the arguments, allowing to usekrakenw querysubcommands from subdirectories.