Allow passing of enabled features to cargo build #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow passing of enabled features to cargo build
Added changelog item.
ntrinquier
requested changes
Jul 13, 2023
morosanmihail
commented
Jul 13, 2023
ntrinquier
reviewed
Jul 13, 2023
j-baker
reviewed
Jul 20, 2023
| @@ -322,6 +323,11 @@ def cargo_build( | |||
| additional_args.append(crate) | |||
| if mode == "release": | |||
| additional_args.append("--release") | |||
| if features: | |||
There was a problem hiding this comment.
out of interest, why are you seeking to enable these features in Kraken, rather than making them be default features in the root project. Basically, what's the use case for this functionality?
There was a problem hiding this comment.
@morosanmihail, I am keen to understand the use case as well :)
There was a problem hiding this comment.
Capturing for posterity: this would be useful to enable platform-specific features (a workaround exists, but it's not great), as well as to have multiple cargo build tasks to produce variants of a binary, with different features combinations.
ntrinquier
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows cargo_build to take a list of strings (features) to pass onto the build task and enable them during compilation.
Despite some examples online recommending to wrap all comma-separated features in a pair of quotes ("abc, bcd"), the official documentation does not mention this as a requirement. To be revisited if problematic.