Fix for an issue where cargo is not correctly recognised as managed by Nix
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by `Nix` --- `which` command does not appear to be following symbolic links on *nix systems. This was causing an issue in this particular case where `cargo` was symlinked from `~/.nix-profile/bin/cargo` to its relevant `/nix/store` location. The fix addresses this issue by using `os.path.realpath` function, which can resolve relative and symbolic paths to cannonical paths on the system. In case the path is already a cannonical path, it's simply returned as is, unchanged.
ivan-jukic
force-pushed
the
bugfix/nix-cargo-realpath
branch
from
1ace46b
to
cd8b2c2
Compare
ivan-jukic
force-pushed
the
bugfix/nix-cargo-realpath
branch
from
5bd6f0a
to
a835503
Compare
skip-checks: true
tetigi
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whichcommand does not appear to be following symbolic links on *nix systems. This was causing an issue in this particular case wherecargowas symlinked from~/.nix-profile/bin/cargoto its relevant/nix/storelocation.The fix addresses this issue by using
os.path.realpathfunction, which can resolve relative and symbolic paths to cannonical paths on the system. In case the path is already a cannonical path, it's simply returned as is, unchanged.