-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying additional directories for Python linting #90
Conversation
@cowlingjosh is this still relevant? |
7722246
to
d553923
Compare
Apologies for the late reply on this @ntrinquier, I missed the email notifications from Github 🤦 Thanks for the review, I have added your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cowlingjosh one last small comment, let me know what you think!
ac4601d
to
1b20b3a
Compare
@ntrinquier thanks again for the suggestions, I have made the changes. I have made two other changes as well:
|
Often projects contain an
examples/
orbin/
directory which contains Python source code, but by default Kraken only lints against source code insrc
andtests
directories.This MR adds the ability to specify any number of extra directories for which lint tasks (
black
,flake8
,isort
,mypy
,pycln
,pylint
) should also be run against. This functionality is exposed via thepython_settings
function which modifies the globalPythonSettings
object.