Fixes Flake8 lint by using is not instead of !=
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
force-pushed
the
tpt/flake8
branch
2 times, most recently
from
3db6328
to
5ca8cd6
Compare
ntrinquier
reviewed
Jul 31, 2023
ntrinquier
approved these changes
Jul 31, 2023
ntrinquier
changed the title
is not instead of !=
|
@Tpt There are more apparently https://github.com/kraken-build/kraken-build/blob/d67179a8f2a93d409cfe3288c967119bfa503cb1/kraken-core/src/kraken/core/system/context_test.py#L47-L54 (Sadly they are not reported at the same time when flake8 fails) |
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already checking type of other...