Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kraken doesn't support Cargo's required-features #134

Closed
asmello opened this issue Dec 5, 2023 · 0 comments · Fixed by #139
Closed

Kraken doesn't support Cargo's required-features #134

asmello opened this issue Dec 5, 2023 · 0 comments · Fixed by #139
Assignees
Labels
type: bug Something isn't working

Comments

@asmello
Copy link
Contributor

asmello commented Dec 5, 2023

Traceback (most recent call last):                                                                             
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/core/cli/main.py", line 203, in _load_build_state                                                                                 
   context.load_project(Path.cwd())                                                                           
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/core/system/context.py", line 1[70], in load_project                                                                               
   runner.execute_script(script, {"project": project})                                                        
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/common/_runner.py", line 113, in execute_script                                                                                  
   exec(code, vars(module))                                                                                                                                                                                                           
[...]                        
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/std/cargo/manifest.py", line 213, in read                                                                                        
   ret = cls.of(path, tomli.load(fp))                                                                         
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/std/cargo/manifest.py", line 227, in of                                                                                          
   [Bin(**x) for x in data.get("bin", [])],                                                                   
 File                                                                                                         
".../.kraken/venv/lib/python3.10/site-packages/kraken/std/cargo/manifest.py", line 227, in <listcomp>                                                                                  
   [Bin(**x) for x in data.get("bin", [])],                                                                   
TypeError: Bin.__init__() got an unexpected keyword argument 'required-features'

Seems that using separate dependencies for a binary target via the second strategy here is not supported by kraken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
2 participants