Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store a flag to know if an environment has been successfully initialized #24

Closed
NiklasRosenstein opened this issue Nov 9, 2022 · 0 comments · Fixed by #162
Closed

Store a flag to know if an environment has been successfully initialized #24

NiklasRosenstein opened this issue Nov 9, 2022 · 0 comments · Fixed by #162
Assignees
@NiklasRosenstein
Labels
only: kraken-wrapper This issue affects only kraken-wrapper. type: enhancement New feature or request

Comments

@NiklasRosenstein
Copy link
Contributor

NiklasRosenstein commented Nov 9, 2022 •
edited

When you cancel kraken-wrapper while it is creating the build environment, the env will be broken and you need to manually remove it. If at the end of the initialization we store a flag to say that everything's good, we can discover if that isn't set and re-initialize the env. Otherwise it results in cryptic errors (most commonly "ModuleNotFoundError: kraken.core")
@NiklasRosenstein NiklasRosenstein added the type: enhancement New feature or request label Nov 9, 2022
@NiklasRosenstein NiklasRosenstein self-assigned this Nov 9, 2022
@NiklasRosenstein NiklasRosenstein transferred this issue from another repository May 15, 2023
@NiklasRosenstein NiklasRosenstein added the only: kraken-wrapper This issue affects only kraken-wrapper. label May 15, 2023
@NiklasRosenstein NiklasRosenstein linked a pull request Jan 10, 2024 that will close this issue
Accept str for some pytest() parameters, use venv --upgrade-deps in kraken-wrapper and store a success flag after build venv creation #162
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiklasRosenstein NiklasRosenstein

Labels
only: kraken-wrapper This issue affects only kraken-wrapper. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@NiklasRosenstein