We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.metric()
The .metric() API feels very awkward atm.
https://github.com/krakenjs/beaver-logger/blob/main/src/logger.js#L291-L304
Currently it's:
function metric(metricPayload: Metric){}
Which requires a .name property for the metric name.
.name
I'm torn on how low-level to make this but maybe having a rawMetric(payload) and another method makes sense.
rawMetric(payload)
So it'd be
.rawMetric(payload); .metric(eventName, namespace, dimensions); .metric("weasley.flow.started", "pp.xo.weasley.custom", { app: 'weasley', isWPS: false, country: 'US', currencyCode: 'USD', releaseHash: 'e1fnrnd' })
Then in sfx this would show up under the pp.xo.weasley.custom metric, with the event_name dimension set to weasley.flow.started
pp.xo.weasley.custom
event_name
weasley.flow.started
Maybe something like this. Still kind of torn on this, but wanted to raise it up. @westeezy
The text was updated successfully, but these errors were encountered:
Nevermind. Forgot that this needs to be generic and backend agnostic.
Sorry, something went wrong.
No branches or pull requests
The
.metric()
API feels very awkward atm.https://github.com/krakenjs/beaver-logger/blob/main/src/logger.js#L291-L304
Currently it's:
Which requires a
.name
property for the metric name.I'm torn on how low-level to make this but maybe having a
rawMetric(payload)
and another method makes sense.So it'd be
Then in sfx this would show up under the
pp.xo.weasley.custom
metric, with theevent_name
dimension set toweasley.flow.started
Maybe something like this. Still kind of torn on this, but wanted to raise it up. @westeezy
The text was updated successfully, but these errors were encountered: