Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

Router options not inherited by default #52

Open
jasisk opened this issue Aug 26, 2014 · 3 comments
Open

Router options not inherited by default #52

jasisk opened this issue Aug 26, 2014 · 3 comments
Assignees

Comments

@jasisk
Copy link
Member

jasisk commented Aug 26, 2014

This issue is related to krakenjs/kraken-js#281.

If a user enables any of the router-specific options in express, they are not inherited by enrouten-based routes. On the one hand, this is expected behavior given these options don't automatically apply to new Router instances as they're not coupled to any particular app instance. On the other hand, enrouten initializing new Router instances is an implementation detail and the behavior should act more like if routes were registered against the express base router.

The express options that apply to the base router are "case sensitive routing" and "strict routing".

@aredridel
Copy link

Definitely inherit from the app. It's all one thing as far as the user can tell.

@totherik
Copy link
Member

Yeah, I think the fact that new routers are an implementation detail supports the fact that app-level settings should be reflected everywhere. From the developer's perspective it's the most obvious, expected behavior.

@totherik
Copy link
Member

totherik commented Dec 9, 2014

Issue #55 allows for explicit configuration of router settings, but still needs to inherit app values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants