You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.
If a user enables any of the router-specific options in express, they are not inherited by enrouten-based routes. On the one hand, this is expected behavior given these options don't automatically apply to new Router instances as they're not coupled to any particular app instance. On the other hand, enrouten initializing new Router instances is an implementation detail and the behavior should act more like if routes were registered against the express base router.
Yeah, I think the fact that new routers are an implementation detail supports the fact that app-level settings should be reflected everywhere. From the developer's perspective it's the most obvious, expected behavior.
This issue is related to krakenjs/kraken-js#281.
If a user enables any of the router-specific options in express, they are not inherited by enrouten-based routes. On the one hand, this is expected behavior given these options don't automatically apply to new
Router
instances as they're not coupled to any particularapp
instance. On the other hand, enrouten initializing newRouter
instances is an implementation detail and the behavior should act more like if routes were registered against the express base router.The express options that apply to the base router are "case sensitive routing" and "strict routing".
The text was updated successfully, but these errors were encountered: