Skip to content
This repository has been archived by the owner on Jan 25, 2020. It is now read-only.

case sensitive routing #54

Closed
Dexus opened this issue Sep 20, 2014 · 4 comments
Closed

case sensitive routing #54

Dexus opened this issue Sep 20, 2014 · 4 comments

Comments

@Dexus
Copy link

Dexus commented Sep 20, 2014

i have enabled case sensitive routing, but i can use mixed strings with upper and lowercase chars.

@sixlettervariables
Copy link

If you've done:

app.set('case sensitive routing', true);

That will only apply to the routes registered directly on the app instance. The routes created by express-enrouten each have their own routers and thus have their own options. No options are passed or inherited:

router = router || new express.Router();

What you need is an option to pass to enrouten that would allow caseSensitive to be passed to each of the routers created.

@Dexus
Copy link
Author

Dexus commented Sep 22, 2014

Thank you for your PR 👍

@sixlettervariables
Copy link

You're welcome, I'd been using something very similar internally and just had not pushed it back this way.

@totherik
Copy link
Member

totherik commented Dec 9, 2014

Should be resolved by #55. Awaiting publish as enrouten@1.2.0.

@totherik totherik closed this as completed Dec 9, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants