Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csrf http2 token validation fails while http1 passes #117

Closed
avoidwork opened this issue Jan 16, 2018 · 2 comments
Closed

csrf http2 token validation fails while http1 passes #117

avoidwork opened this issue Jan 16, 2018 · 2 comments

Comments

@avoidwork
Copy link

hi,

the timeSafeCompare() function appears to fail for http2 requests, while http1 works fine. my env is running node 9.4.0, and my tests for the 2 protocols are equal.

http1 input:
screen shot 2018-01-16 at 7 32 09 am

http2 input:
screen shot 2018-01-16 at 7 32 31 am

the nodejs 9.4 changelog doesn't mention any crypto changes, so i'm confused: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V9.md#9.4.0
@avoidwork avoidwork changed the title http2 token validation fails while http1 passes csrf http2 token validation fails while http1 passes Jan 16, 2018
@avoidwork
Copy link
Author

maybe this is related to #43?

@avoidwork
Copy link
Author

nm, pebcak (cookie is missing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avoidwork