Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroyNemo not properly called in Suite.afterAll in mocha.js #57

Closed
LucasMaupin opened this issue Jan 15, 2019 · 4 comments
Closed

destroyNemo not properly called in Suite.afterAll in mocha.js #57

LucasMaupin opened this issue Jan 15, 2019 · 4 comments

Comments

@LucasMaupin
Copy link
Contributor

I am currently trying out your framework and enjoying it so far! However, when I test in parallel the drivers never quit. I am testing using browserstack and it can be very problematic. I changed:
Suite.afterAll(function(){
destroyNemo.call(this)
})
to
Suite.afterAll(destroyNemo);
in mocha.js and it solved the issue.

@LucasMaupin
Copy link
Contributor Author

I created a pull request as well now.

@LucasMaupin
Copy link
Contributor Author

or:
Suite.afterAll(function() {
return destroyNemo.call(this)
});

@grawk
Copy link
Member

grawk commented Mar 8, 2019

Hi @LucasMaupin Very sorry I didn't see this until now. Thank you for finding the fix here.

@grawk
Copy link
Member

grawk commented Mar 8, 2019

Fixed in v4.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants