Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-my-json-valid as json schema validator #30

Closed
vh opened this issue Feb 13, 2015 · 7 comments
Closed

is-my-json-valid as json schema validator #30

vh opened this issue Feb 13, 2015 · 7 comments
Milestone

Comments

@vh
Copy link
Contributor

vh commented Feb 13, 2015

It seems is-my-json-valid can be good alternative to enjoi. It is superfast in comparison with the others validators (https://github.com/Muscula/json-schema-benchmark). What do you think about this?

@vh
Copy link
Contributor Author

vh commented Feb 13, 2015

Just added benchmark tlivings/enjoi#4

@tlivings
Copy link
Member

Have you seen the results for themis?

@tlivings
Copy link
Member

It's not just raw performance I was going for with enjoi, but rather hapi compatibility.

That being said, I'll likely switch out non hapi code to use more traditional json-schema validation unless I knock out 100% compatibility soon.

@tlivings
Copy link
Member

Although looking at it - it seems quite fast.

@vh
Copy link
Contributor Author

vh commented Feb 16, 2015

Ahh, ok. You mean that it is needed to implement some missing enjoi keywords support to be able to switch out?

@tlivings
Copy link
Member

No, enjoi is missing json-schema keywords - it doesn't yet do a perfect conversion from json-schena to Joi.

But the reason I wrote enjoi was to provide not only fast (at the time I had used tv4 which felt slow) validation, but schemas that were compatible with Hapi (which uses Joi for validation).

@tlivings
Copy link
Member

For this to be more acceptable, I will need to consider writing custom validator function from swaggerize-hapi instead of using joi schemas. That might be fine, but I'll need to play with it some first.

@subeeshcbabu-zz subeeshcbabu-zz added this to the v2.0.0 milestone Jul 11, 2016
@subeeshcbabu-zz subeeshcbabu-zz mentioned this issue Oct 25, 2016
Merged
@vh vh closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants