feat(venmo): allow trusted domains #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 95.57% 95.58%
=======================================
Files 18 18
Lines 1220 1222 +2
=======================================
+ Hits 1166 1168 +2
Misses 54 54
☔ View full report in Codecov by Sentry. |
wsbrunson
reviewed
Jun 12, 2023
| @@ -813,6 +813,73 @@ describe("zoid props cases", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it("should pass a trustedDomain prop and have it populate on the child", () => { | |||
There was a problem hiding this comment.
we should add a test where the domains don't match
url: "mock://www.child.com/base/test/windows/child/index.htm",
trustedDomains: ["mock://www.different-domain.com"],
mnicpt
force-pushed
the
feature/trustedDomains
branch
from
c226a35
to
6e7f70a
Compare
wsbrunson
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows trusted domains to be specified for passing props to children with different domain.
https://paypal.atlassian.net/browse/DTCHKINT-1568