make test: 70% of tests are failing

[sr78ger]

Hi.

I'm trying to build pthreads (0.45) using php 5.5.6, 5.4.22, 5.3.27 on CentOS6.5. I've tried several methods: building php with --enable-pthreads=static and --enable-maintainer-zts or as an module.

Number of tests : 40 40
Tests skipped : 0 ( 0.0%) --------
Tests warned : 0 ( 0.0%) ( 0.0%)
Tests failed : 28 ( 70.0%) ( 70.0%)
Expected fail : 0 ( 0.0%) ( 0.0%)
Tests passed : 12 ( 30.0%) ( 30.0%)

php -dextension=pthreads.so --ri=pthreads
pthreads
Version => 0.45-rc

./configure
--with-libdir=lib64
--with-layout=PHP
--with-pear
--with-apxs2
--enable-calendar
--enable-bcmath
--with-gmp
--enable-exif
--with-mcrypt
--with-mhash
--with-zlib
--with-bz2
--enable-zip
--enable-ftp
--enable-mbstring
--with-iconv
--enable-intl
--with-icu-dir=/usr
--with-gettext
--with-pspell
--enable-sockets
--with-openssl
--with-curl
--with-curlwrappers
--with-gd
--enable-gd-native-ttf
--with-jpeg-dir=/usr
--with-png-dir=/usr
--with-zlib-dir=/usr
--with-xpm-dir=/usr
--with-vpx-dir=/usr
--with-freetype-dir=/usr
--with-t1lib=/usr
--with-libxml-dir=/usr
--with-mysql=mysqlnd
--with-mysqli=mysqlnd
--with-pdo-mysql=mysqlnd
--enable-soap
--with-xmlrpc
--with-xsl
--with-tidy=/usr
--with-readline
--enable-libxml
--enable-xml
--enable-dom
--enable-simplexml
--enable-xmlreader
--enable-xmlwriter
--enable-pcntl
--enable-sysvshm
--enable-sysvmsg
--enable-shmop
--enable-maintainer-zts
--enable-cli

make
make test

Thanks in advance
Stefab

[sr78ger]

FAILED TEST SUMMARY

Test pthreads connections [tests/binding.phpt]
Testing extended object functionality, magic methods bug #34 [tests/callstatic-etc.phpt]
Test NULLing ressources in arrays [tests/complex-statics-set-null.phpt]
Test complex statics bug #32 [tests/complex-statics.phpt]
Test conditions [tests/conditions.phpt]
Test constants (bug 19) [tests/constants.phpt]
Testing sane handling of resources and objects bug #39 [tests/corrupted-resources.phpt]
Test detach is successful [tests/detach.phpt]
Test doc comments are copied properly [tests/doc-comments.phpt]
Testing foreign private member access, magic methods bug #32 [tests/foreign-private-members.phpt]
Test function table inheritance [tests/functions.phpt]
Test global constants [tests/global-constants.phpt]
Test graceful fatalities [tests/graceful-fatalities.phpt]
Test include/require functions as expected [tests/included-files.phpt]
Test INI inheritance (bug 20) [tests/ini.phpt]
Test interface functionality [tests/interface.phpt]
Testing interfaces inheritance (#124) [tests/interfaces.phpt]
Test reading object properties without debug info [tests/normal-reads.phpt]
Test access to user defined methods in the object context [tests/oomethods.phpt]
Test selective inheritance [tests/selective-inheritance.phpt]
Test stateful fatalities [tests/stateful-fatalities.phpt]
Test access to static methods from within user threads [tests/staticmethods.phpt]
Test statics (bug 19) [tests/statics.phpt]
Test synchronized blocks [tests/synchronization.phpt]
Test basic threading [tests/thread.phpt]
Test unset defaults [moot: default values are ignored] [tests/unset-defaults.phpt]
Test wait/notify [tests/wait.phpt]
Test waiting timeouts [tests/waiting-timeouts.phpt]

[krakjoe]

can you show me some diffs?

remarkably similar: #165

[sr78ger]

my steps for building pthreads as a module.. I will give pthreads embedded a try ...

build php 5.5.6 with pthreads as module

rm ./configure
rm -rf autom4te.cache/
rm -rf aclocal.m4
./buildconf --force

(removing an buildconf like suggested in #62)

./configure \
--with-libdir=lib64 \
--with-layout=PHP \
--with-pear \
--with-apxs2 \
--enable-calendar \
--enable-bcmath \
--with-gmp \
--enable-exif \
--with-mcrypt \
--with-mhash \
--with-zlib \
--with-bz2 \
--enable-zip \
--enable-ftp \
--enable-mbstring \
--with-iconv \
--enable-intl \
--with-icu-dir=/usr \
--with-gettext \
--with-pspell \
--enable-sockets \
--with-openssl \
--with-curl \
--with-curlwrappers \
--with-gd \
--enable-gd-native-ttf \
--with-jpeg-dir=/usr \
--with-png-dir=/usr \
--with-zlib-dir=/usr \
--with-xpm-dir=/usr \
--with-vpx-dir=/usr \
--with-freetype-dir=/usr \
--with-t1lib=/usr \
--with-libxml-dir=/usr \
--with-mysql=mysqlnd \
--with-mysqli=mysqlnd \
--with-pdo-mysql=mysqlnd \
--enable-soap \
--with-xmlrpc \
--with-xsl \
--with-tidy=/usr \
--with-readline \
--enable-libxml \
--enable-xml \
--enable-dom \
--enable-simplexml \
--enable-xmlreader \
--enable-xmlwriter \
--enable-pcntl \
--enable-sysvshm \
--enable-sysvmsg \
--enable-shmop \
--enable-maintainer-zts \
--enable-cli

building...

make
make install

$ which php
/usr/local/bin/php

$ php -i | grep Thread
Thread Safety => enabled

$php -v
PHP 5.5.6 (cli) (built: Dec  4 2013 14:47:40)
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2013 Zend Technologies

building pthreads module*

cd ~/pthreads
phpize
./configure --with-php-config=/usr/local/bin/php-config
make
make test

(using --with-php-config as suggested in #165)

results

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :   28 ( 70.0%) ( 70.0%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   12 ( 30.0%) ( 30.0%)

[krakjoe]

Diffs ?? (in tests/ directory)

[sr78ger]

building into php

I've cloned pthreads into the ext/ path and

rm ./configure
rm -rf autom4te.cache/
rm -rf aclocal.m4
./buildconf --force

make clean

used configure like above, but added: --enable-pthreads

make
make test

FAILED TEST SUMMARY
[...]
Test pthreads connections [ext/pthreads/tests/binding.phpt]
Testing extended object functionality, magic methods bug #34 [ext/pthreads/tests/callstatic-etc.phpt]
Test NULLing ressources in arrays [ext/pthreads/tests/complex-statics-set-null.phpt]
Test complex statics bug #32 [ext/pthreads/tests/complex-statics.phpt]
Test conditions [ext/pthreads/tests/conditions.phpt]
Test constants (bug 19) [ext/pthreads/tests/constants.phpt]
Testing sane handling of resources and objects bug #39 [ext/pthreads/tests/corrupted-resources.phpt]
Test detach is successful [ext/pthreads/tests/detach.phpt]
Test doc comments are copied properly [ext/pthreads/tests/doc-comments.phpt]
Testing foreign private member access, magic methods bug #32 [ext/pthreads/tests/foreign-private-members.phpt]
Test function table inheritance [ext/pthreads/tests/functions.phpt]
Test global constants [ext/pthreads/tests/global-constants.phpt]
Test graceful fatalities [ext/pthreads/tests/graceful-fatalities.phpt]
Test include/require functions as expected [ext/pthreads/tests/included-files.phpt]
Test INI inheritance (bug 20) [ext/pthreads/tests/ini.phpt]
Test interface functionality [ext/pthreads/tests/interface.phpt]
Testing interfaces inheritance (#124) [ext/pthreads/tests/interfaces.phpt]
Test reading object properties without debug info [ext/pthreads/tests/normal-reads.phpt]
Test access to user defined methods in the object context [ext/pthreads/tests/oomethods.phpt]
Test selective inheritance [ext/pthreads/tests/selective-inheritance.phpt]
Test stateful fatalities [ext/pthreads/tests/stateful-fatalities.phpt]
Test access to static methods from within user threads [ext/pthreads/tests/staticmethods.phpt]
Test statics (bug 19) [ext/pthreads/tests/statics.phpt]
Test synchronized blocks [ext/pthreads/tests/synchronization.phpt]
Test basic threading [ext/pthreads/tests/thread.phpt]
Test unset defaults [moot: default values are ignored] [ext/pthreads/tests/unset-defaults.phpt]
Test wait/notify [ext/pthreads/tests/wait.phpt]
Test waiting timeouts [ext/pthreads/tests/waiting-timeouts.ph
[...]

[sr78ger]

complex-statics-set-null.diff

011- file::_get: something3
012- array(2) {
013-   [%i]=>
014-   NULL
015-   [%i]=>
016-   resource(2) of type (stream)
017- }
018- file::_get: something4
019- array(2) {
020-   [%i]=>
021-   NULL
022-   [%i]=>
023-   resource(2) of type (stream)
024- }
``

[sr78ger]

thread.diff

001+
001- bool(true)

[krakjoe]

There is something wrong with your setup:

[joe@fiji php-5.5.6]$ cat config.nice
#! /bin/sh
#
# Created by configure

'./configure' \
'--with-libdir=lib64' \
'--with-layout=PHP' \
'--with-pear' \
'--with-apxs2' \
'--enable-calendar' \
'--enable-bcmath' \
'--with-gmp' \
'--enable-exif' \
'--with-mcrypt' \
'--with-mhash' \
'--with-zlib' \
'--with-bz2' \
'--enable-zip' \
'--enable-ftp' \
'--enable-mbstring' \
'--with-iconv' \
'--enable-intl' \
'--with-icu-dir=/usr' \
'--with-gettext' \
'--enable-sockets' \
'--with-openssl' \
'--with-curl' \
'--with-curlwrappers' \
'--with-gd' \
'--enable-gd-native-ttf' \
'--with-jpeg-dir=/usr' \
'--with-png-dir=/usr' \
'--with-zlib-dir=/usr' \
'--with-xpm-dir=/usr' \
'--with-freetype-dir=/usr' \
'--with-t1lib=/usr' \
'--with-libxml-dir=/usr' \
'--with-mysql=mysqlnd' \
'--with-mysqli=mysqlnd' \
'--with-pdo-mysql=mysqlnd' \
'--enable-soap' \
'--with-xmlrpc' \
'--with-xsl' \
'--with-tidy=/usr' \
'--with-readline' \
'--enable-libxml' \
'--enable-xml' \
'--enable-dom' \
'--enable-simplexml' \
'--enable-xmlreader' \
'--enable-xmlwriter' \
'--enable-pcntl' \
'--enable-sysvshm' \
'--enable-sysvmsg' \
'--enable-shmop' \
'--enable-maintainer-zts' \
'--enable-cli' \
'--enable-pthreads' \
"$@"

[joe@fiji php-5.5.6]$ make test TESTS=ext/pthreads/tests

Build complete.
Don't forget to run 'make test'.


=====================================================================
PHP         : /usr/src/php-5.5.6/sapi/cli/php 
PHP_SAPI    : cli
PHP_VERSION : 5.5.6
ZEND_VERSION: 2.5.0
PHP_OS      : Linux - Linux fiji 3.9.10-100.fc17.x86_64 #1 SMP Sun Jul 14 01:31:27 UTC 2013 x86_64
INI actual  : /usr/src/php-5.5.6/tmp-php.ini
More .INIs  :  
CWD         : /usr/src/php-5.5.6
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
Running selected tests.
PASS Test pthreads connections [ext/pthreads/tests/binding.phpt] 
PASS Testing extended object functionality, magic methods bug #34 [ext/pthreads/tests/callstatic-etc.phpt] 
PASS Check chunking [ext/pthreads/tests/chunk.phpt] 
PASS Test NULLing ressources in arrays [ext/pthreads/tests/complex-statics-set-null.phpt] 
PASS Test complex statics bug #32 [ext/pthreads/tests/complex-statics.phpt] 
PASS Test conditions [ext/pthreads/tests/conditions.phpt] 
PASS Test constants (bug 19) [ext/pthreads/tests/constants.phpt] 
PASS Testing sane handling of resources and objects bug #39 [ext/pthreads/tests/corrupted-resources.phpt] 
PASS Testing member count [ext/pthreads/tests/counting-members.phpt] 
PASS Test detach is successful [ext/pthreads/tests/detach.phpt] 
PASS Test doc comments are copied properly [ext/pthreads/tests/doc-comments.phpt] 
PASS Testing foreign private member access, magic methods bug #32 [ext/pthreads/tests/foreign-private-members.phpt] 
PASS Test function table inheritance [ext/pthreads/tests/functions.phpt] 
PASS Test global constants [ext/pthreads/tests/global-constants.phpt] 
FAIL Test objects that have gone away [ext/pthreads/tests/gone.phpt] 
PASS Test graceful fatalities [ext/pthreads/tests/graceful-fatalities.phpt] 
PASS Test include/require functions as expected [ext/pthreads/tests/included-files.phpt] 
PASS Test INI inheritance (bug 20) [ext/pthreads/tests/ini.phpt] 
PASS Test interface functionality [ext/pthreads/tests/interface.phpt] 
PASS Testing interfaces inheritance (#124) [ext/pthreads/tests/interfaces.phpt] 
PASS Testing isset unset [ext/pthreads/tests/isset-unset.phpt] 
PASS Testing merging members [ext/pthreads/tests/merging-members.phpt] 
PASS Testing merging members (long keys) [ext/pthreads/tests/merging-range.phpt] 
PASS Test mutex operations [ext/pthreads/tests/mutex.phpt] 
PASS Test members (typeof object) with no other references [ext/pthreads/tests/norefs.phpt] 
PASS Test reading object properties without debug info [ext/pthreads/tests/normal-reads.phpt] 
PASS Testing normalizing members [ext/pthreads/tests/normalize-members.phpt] 
PASS Null member crash [ext/pthreads/tests/null-member-crash.phpt] 
PASS Test access to user defined methods in the object context [ext/pthreads/tests/oomethods.phpt] 
PASS Test selective inheritance [ext/pthreads/tests/selective-inheritance.phpt] 
PASS Test shift and pop [ext/pthreads/tests/shift-pop.phpt] 
PASS Test stateful fatalities [ext/pthreads/tests/stateful-fatalities.phpt] 
PASS Test access to static methods from within user threads [ext/pthreads/tests/staticmethods.phpt] 
PASS Test statics (bug 19) [ext/pthreads/tests/statics.phpt] 
PASS Test synchronized blocks [ext/pthreads/tests/synchronization.phpt] 
PASS Testing thorn in my side hasn't returned [ext/pthreads/tests/thorn-in-side.phpt] 
PASS Test basic threading [ext/pthreads/tests/thread.phpt] 
PASS Test unset defaults [moot: default values are ignored] [ext/pthreads/tests/unset-defaults.phpt] 
PASS Test wait/notify [ext/pthreads/tests/wait.phpt] 
PASS Test waiting timeouts [ext/pthreads/tests/waiting-timeouts.phpt] 
=====================================================================
Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    1 (  2.5%) (  2.5%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   39 ( 97.5%) ( 97.5%)
---------------------------------------------------------------------
Time taken      :    2 seconds
=====================================================================

(that fail is semi expected)

Any chance you can grant me access to the machine this is happening on ??

Other wise, try executing one of the examples and providing me the backtrace and errors from that ...

[sr78ger]

Thanks for your quick response. I'll try to move the machine, so you can get access from remote.

In the meanwhile I've switched from CentOS 6.5 to Debian 7.2 and tried it with the same configure command and even just with

./configure \
--enable-maintainer-zts \
--enable-pthreads

The debian installation was a clean install without any third party packages. Just

• downloaded php-5.5.6 source
• downloaded phtreads into ext/

rm ./configure
./buildconf --force

...and the same tests are failing.

[chibisuke]

which arch are you running?
(x86, x86_64, ia64, alpha, sparc, ...)

[sr78ger]

Tested with debian

Linux debian 3.2.0-4-amd64 #1 SMP Debian 3.2.51-1 x86_64 GNU/Linux

and CentOS x86_64

Linux soatest.local 2.6.32-431.el6.x86_64 #1 SMP Fri Nov 22 03:15:09 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux

A second ago I figured out, that the test passed when I configure with ``--disable-all`

./configure --disable-all --enable-pthreads --enable-maintainer-zts

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    1 (  2.5%) (  2.5%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   39 ( 97.5%) ( 97.5%)

[sr78ger]

After configure like suggested here #58 (comment)

cat config.nice
#! /bin/sh
#
# Created by configure

'./configure' \
'--enable-debug' \
'--enable-pthreads' \
'--enable-maintainer-zts' \
'--disable-cli' \
'--enable-cli' \
"$@"

the tests a failing again:

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :   28 ( 70.0%) ( 70.0%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   12 ( 30.0%) ( 30.0%)

[sr78ger]

Just want you to know, that I'm able to run one of the examples

https://raw.github.com/krakjoe/pthreads/master/examples/Stacking.php

after getting it working with:

./configure --disable-all --enable-pthreads --enable-maintainer-zts --enable-cli

I just hope, that there's a better solution than --disable-all

Thanks a lot for your great support

[Carmolo]

i had the same issue with the configure from here

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :   28 ( 70.0%) ( 70.0%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   12 ( 30.0%) ( 30.0%)
---------------------------------------------------------------------
Time taken      :    0 seconds

than i tried

./configure --prefix=/usr --enable-maintainer-zts --with-pear \
--with-config-file-path=/etc --with-readline --with-mcrypt \
--with-zlib --enable-mbstring --with-curl --with-bz2 \
--enable-zip --enable-sockets --enable-sysvsem --enable-sysvshm \
--with-mhash --with-pcre-regex --with-gettext --enable-bcmath \
--enable-libxml --enable-json --with-openssl --enable-pcntl --enable-pthreads

and the result was

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    1 (  2.5%) (  2.5%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   39 ( 97.5%) ( 97.5%)

[krakjoe]

I would be interested to know which extension is causing the failure, if that is the problem ...

[sr78ger]

After a many dozens of builds I finally isolated the extension. It's session.

The build after

`./configure --disable-all --enable-maintainer-zts --enable-pthreads``

passes all tests.

But

`./configure --disable-all --enable-maintainer-zts --enable-pthreads --enable-session``

is failing

Test pthreads connections [ext/pthreads/tests/binding.phpt]
Testing extended object functionality, magic methods bug #34 [ext/pthreads/tests/callstatic-etc.phpt]
Test NULLing ressources in arrays [ext/pthreads/tests/complex-statics-set-null.phpt]
Test complex statics bug #32 [ext/pthreads/tests/complex-statics.phpt]
Test conditions [ext/pthreads/tests/conditions.phpt]
Test constants (bug 19) [ext/pthreads/tests/constants.phpt]
Testing sane handling of resources and objects bug #39 [ext/pthreads/tests/corrupted-resources.phpt]
Test detach is successful [ext/pthreads/tests/detach.phpt]
Test doc comments are copied properly [ext/pthreads/tests/doc-comments.phpt]
Testing foreign private member access, magic methods bug #32 [ext/pthreads/tests/foreign-private-members.phpt]
Test function table inheritance [ext/pthreads/tests/functions.phpt]
Test global constants [ext/pthreads/tests/global-constants.phpt]
Test objects that have gone away [ext/pthreads/tests/gone.phpt]
Test graceful fatalities [ext/pthreads/tests/graceful-fatalities.phpt]
Test include/require functions as expected [ext/pthreads/tests/included-files.phpt]
Test INI inheritance (bug 20) [ext/pthreads/tests/ini.phpt]
Test interface functionality [ext/pthreads/tests/interface.phpt]
Testing interfaces inheritance (#124) [ext/pthreads/tests/interfaces.phpt]
Test reading object properties without debug info [ext/pthreads/tests/normal-reads.phpt]
Test access to user defined methods in the object context [ext/pthreads/tests/oomethods.phpt]
Test selective inheritance [ext/pthreads/tests/selective-inheritance.phpt]
Test stateful fatalities [ext/pthreads/tests/stateful-fatalities.phpt]
Test access to static methods from within user threads [ext/pthreads/tests/staticmethods.phpt]
Test statics (bug 19) [ext/pthreads/tests/statics.phpt]
Test synchronized blocks [ext/pthreads/tests/synchronization.phpt]
Testing thorn in my side hasn't returned [ext/pthreads/tests/thorn-in-side.phpt]
Test basic threading [ext/pthreads/tests/thread.phpt]
Test unset defaults [moot: default values are ignored] [ext/pthreads/tests/unset-defaults.phpt]
Test wait/notify [ext/pthreads/tests/wait.phpt]
Test waiting timeouts [ext/pthreads/tests/waiting-timeouts.phpt]

I performed all builds/tests on a clean installation of Debian x86_64. I will double-check this result on CentOS 6.5 as well.

[sr78ger]

Just verified the result on CenOS 6

Number of tests :   40                40
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :   28 ( 70.0%) ( 70.0%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :   12 ( 30.0%) ( 30.0%)

[krakjoe]

I can consistently pass all tests with this config.nice

#! /bin/sh
#
# Created by configure

'./configure' \
'--disable-all' \
'--enable-maintainer-zts' \
'--enable-pthreads' \
'--enable-session' \
"$@"

With a 5.5.6 checkout. My OS is fedora core, so I shouldn't expect it to be any different to, at the very least, Cent OS, it should behave exactly the same.

Can you checkout b7ebd3a, see if that's where the bug was introduced (in the commit after that one, I think)

It's pretty hard to debug something I cannot reproduce, if you can organize access to a machine where this occurs, it would be a great help to everyone ...

[sr78ger]

Thanks alot. I'm working on a machine with remote access. I'm waiting on approval of the necessary firewall rules.

On my CentOS box I tried the following

cd ext/pthreads
git reset --hard b7ebd3a75b47d32bee058b50ac945cd6ea16714e
cd ../../
make distclean
./buildconf --force
./configure --disable-all --enable-pthreads --enable-maintainer-zts --enable-session
make
make test TESTS=ext/pthreads/tests

tests passed

Tests passed    :   39 ( 97.5%) ( 97.5%)

`make install``

# php -m
[PHP Modules]
Core
date
ereg
pcre
pthreads
Reflection
session
SPL
standard

Stacking.php

cd ~
php Stacking.php

Stacking: 1/1
Stacking: 2/2
Stacking: 3/3
Stacking: 4/4
Stacking: 5/5
Stacking: 6/6
Stacking: 7/7
Stacking: 8/8
Stacking: 9/9
Stacking: 10/10
Setup ExampleWorker (140301123585792) Complete
Running Work in ExampleWorker (140301123585792)
Work Object
(
    [local] => Array
[...]

[sr78ger]

I finally managed it and can give you access to my CentOS machine.

[krakjoe]

Excellent, you can find me on #php.pecl or #phpdbg on efnet

[emiglobetrotting]

Trying to reinstall php7 (zts) + pthreads on ubuntu 14.04 with this installation which was working and yields pass result of about 90% but now test pass result is 21.7%. Please help me.