When passing a thread object in worker to other methods, their first sibling in the stack is passed

[zerustech]

If you know how to write phpt tests, please open a PR with environment information, and your test, this will cause CI to test your issue before a human is able to look

Environment

• PHP: 5.6.14
• pthreads: 2.0.10
• OS: Mac OS X 10.11.5

Summary

When passing a thread object in worker to other methods, their first sibling in the worker stack is passed.

Reproducing Code

<?php                                                                                                                    

class Inventory extends Threaded                                                                                         
{                                                                                                                        
    private $queue;                                                                                                      

    public function __construct(Threaded $queue)                                                                         
    {                                                                                                                    
        $this->queue = $queue;                                                                                           
    }                                                                                                                    

    public function put(Thread $producer, $product)                                                                      
    {                                                                                                                    
        $this->queue[] = $product;                                                                                       

        printf("[%s] instance [%s] in worker [%s] is producing now ...\n\n", get_class($producer), $producer->name, $producer->worker->name);
    }                                                                                                                    

}                                                                                                                        

class ProducerFoo extends Thread                                                                                         
{                                                                                                                        
    private $name;                                                                                                       

    public function __construct($name)                                                                                   
    {                                                                                                                    
        $this->name = $name;                                                                                             
    }                                                                                                                    

    public function run()                                                                                                
    {                                                                                                                    
        printf("[ProducerFoo] [%s] in worker [%s] is about to run ...\n", $this->name, $this->worker->name);             
        $this->worker->inventory->put($this, '*');                                                                       
    }                                                                                                                    
}                                                                                                                        

class ProducerBar extends Thread                                                                                         
{                                                                                                                        
    private $name;                                                                                                       

    public function __construct($name)                                                                                   
    {                                                                                                                    
        $this->name = $name;                                                                                             
    }                                                                                                                    

    public function run()                                                                                                
    {                                                                                                                    
        printf("[ProducerBar] [%s] in worker [%s] is about to run ...\n", $this->name, $this->worker->name);             
        $this->worker->inventory->put($this, '*');                                                                       
    }                                                                                                                    
}                                                                                                                                                                                                                                                                     
$queue = new Threaded();                                                                                                 
$inventory = new Inventory($queue);  

$p1 = new ProducerFoo('p1');                                                                                             
$p2 = new ProducerFoo('p2');                                                                                             
$p3 = new ProducerBar('p3');                                                                                             

$worker = new Worker();                                                                                                  
$worker->inventory = $inventory;                                                                                         
$worker->name = "w1";                                                                                                    

$worker->stack($p1);                                                                                                     
$worker->stack($p2);                                                                                                     
$worker->stack($p3);                                                                                                     

$worker->start();                                                                                                        
$worker->shutdown();  

Expected Output

[ProducerFoo] [p1] in worker [w1] is about to run ...
[ProducerFoo] instance [p1] in worker [w1] is producing now ...

[ProducerFoo] [p2] in worker [w1] is about to run ...
[ProducerFoo] instance [p1] in worker [w1] is producing now ...

[ProducerBar] [p3] in worker [w1] is about to run ...
[ProducerBar] instance [p3] in worker [w1] is producing now ...

Actual Output

[ProducerFoo] [p1] in worker [w1] is about to run ...
[ProducerFoo] instance [p1] in worker [w1] is producing now ...

[ProducerFoo] [p2] in worker [w1] is about to run ...
[ProducerFoo] instance [p1] in worker [w1] is producing now ...

[ProducerBar] [p3] in worker [w1] is about to run ...
[ProducerFoo] instance [p1] in worker [w1] is producing now ...

[zerustech]

This works with PHP 7 and the V3 API

[krakjoe]

I'm no longer working on v2 actively, I don't have the time.

Upgrade PHP ;)