/
diagnostics.go
608 lines (542 loc) · 16.5 KB
/
diagnostics.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
package lsp
import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
"slices"
"strings"
"sync"
"time"
"github.com/kralicky/protocompile"
"github.com/kralicky/protocompile/ast"
"github.com/kralicky/protocompile/linker"
"github.com/kralicky/protocompile/parser"
"github.com/kralicky/protocompile/reporter"
"github.com/kralicky/tools-lite/gopls/pkg/protocol"
)
// func (c *Cache) ComputeDiagnosticReports(uri protocol.DocumentURI, prevResultId string) ([]protocol.Diagnostic, protocol.DocumentDiagnosticReportKind, string, error) {
// c.resultsMu.RLock()
// defer c.resultsMu.RUnlock()
// var maybePrevResultId []string
// if prevResultId != "" {
// maybePrevResultId = append(maybePrevResultId, prevResultId)
// }
// path, err := c.resolver.URIToPath(uri)
// if err != nil {
// slog.With(
// "error", err,
// "uri", string(uri),
// ).Error("failed to resolve uri to path")
// return nil, protocol.DiagnosticUnchanged, "", nil
// }
// rawReports, resultId, unchanged := c.diagHandler.GetDiagnosticsForPath(path, maybePrevResultId...)
// if unchanged {
// return nil, protocol.DiagnosticUnchanged, resultId, nil
// }
// protocolReports := c.toProtocolDiagnostics(rawReports)
// if protocolReports == nil {
// protocolReports = []protocol.Diagnostic{}
// }
// return protocolReports, protocol.DiagnosticFull, resultId, nil
// }
func (c *Cache) toProtocolDiagnostics(rawReports []*ProtoDiagnostic) []protocol.Diagnostic {
reports := make([]protocol.Diagnostic, 0)
for _, rawReport := range rawReports {
var relatedInformation []protocol.DiagnosticRelatedInformation
for _, info := range rawReport.RelatedInformation {
u, err := c.resolver.PathToURI(string(info.Range.Start().Filename))
if err == nil {
relatedInformation = append(relatedInformation, protocol.DiagnosticRelatedInformation{
Location: protocol.Location{
URI: u,
Range: toRange(info.Range),
},
Message: info.Message,
})
}
}
if rawReport.Severity == protocol.SeverityWarning && rawReport.WerrorCategory != "" {
// look up Werror debug pragma for this file
shouldElevate := true
if p, ok := c.FindPragmasByPath(protocompile.ResolvedPath(rawReport.Path)); ok {
if dbg, ok := p.Lookup(PragmaDebug); ok {
for _, v := range strings.Fields(dbg) {
if k, v, ok := strings.Cut(v, "="); ok {
if k == PragmaDebugWnoerror && (v == rawReport.WerrorCategory || v == WnoerrorAll) {
shouldElevate = false
break
}
}
}
}
}
if shouldElevate {
rawReport.Severity = protocol.SeverityError
}
}
report := protocol.Diagnostic{
Range: toRange(rawReport.Range),
Severity: rawReport.Severity,
Message: rawReport.Error.Error(),
Tags: rawReport.Tags,
RelatedInformation: relatedInformation,
Source: "protols",
}
if rawReport.WerrorCategory != "" {
report.Code = rawReport.WerrorCategory
}
data := DiagnosticData{
Metadata: rawReport.Metadata,
CodeActions: rawReport.CodeActions,
}
jsonData, err := json.Marshal(data)
if err != nil {
panic(err)
}
rawMsg := json.RawMessage(jsonData)
report.Data = &rawMsg
reports = append(reports, report)
}
return reports
}
type workspaceDiagnosticCallbackFunc = func(uri protocol.DocumentURI, reports []protocol.Diagnostic, kind protocol.DocumentDiagnosticReportKind, resultId string)
func (c *Cache) StreamWorkspaceDiagnostics(ctx context.Context, ch chan<- protocol.WorkspaceFullDocumentDiagnosticReport) {
c.diagHandler.Stream(ctx, func(path string, resultId string, diagnostics []*ProtoDiagnostic) {
uri, err := c.resolver.PathToURI(path)
if err != nil {
return
}
ch <- protocol.WorkspaceFullDocumentDiagnosticReport{
URI: uri,
Version: c.documentVersions.Get(uri),
FullDocumentDiagnosticReport: protocol.FullDocumentDiagnosticReport{
Kind: string(protocol.DiagnosticFull),
ResultID: resultId,
Items: c.toProtocolDiagnostics(diagnostics),
},
}
})
}
type ProtoDiagnostic struct {
Path string
Version int32
Range ast.SourceSpan
Severity protocol.DiagnosticSeverity
Error error
Tags []protocol.DiagnosticTag
RelatedInformation []RelatedInformation
CodeActions []CodeAction
Metadata map[string]string
// If this is a warning being treated as an error, WerrorCategory will be set to
// a category that can be named in a debug pragma to disable it.
WerrorCategory string
}
type RelatedInformation struct {
Range ast.SourceSpan
Message string
}
const (
diagnosticKind = "kind"
diagnosticKindUndeclaredName = "undeclaredName"
diagnosticKindUnusedImport = "unusedImport"
)
type DiagnosticData struct {
CodeActions []CodeAction `json:"codeActions"`
Metadata map[string]string `json:"metadata"`
}
type CodeAction struct {
Title string `json:"title"`
Path string `json:"path,omitempty"`
Kind protocol.CodeActionKind `json:"kind,omitempty"`
IsPreferred bool `json:"isPreferred,omitempty"`
Edits []protocol.TextEdit `json:"edit,omitempty"`
Command *protocol.Command `json:"command,omitempty"`
}
func NewDiagnosticHandler() *DiagnosticHandler {
return &DiagnosticHandler{
diagnostics: map[string]*DiagnosticList{},
}
}
type DiagnosticList struct {
lock sync.RWMutex
diagnostics []*ProtoDiagnostic
resultId string
dirty bool
}
func (dl *DiagnosticList) Add(d *ProtoDiagnostic) {
if d == nil {
panic("bug: DiagnosticList: attempted to add nil diagnostic")
}
dl.lock.Lock()
defer dl.lock.Unlock()
dl.diagnostics = append(dl.diagnostics, d)
dl.resetResultId()
}
func (dl *DiagnosticList) Get(prevResultId ...string) (diagnostics []*ProtoDiagnostic, resultId string, unchanged bool) {
dl.lock.RLock()
defer dl.lock.RUnlock()
return dl.getLocked(prevResultId...)
}
func (dl *DiagnosticList) getLocked(prevResultId ...string) (diagnostics []*ProtoDiagnostic, resultId string, unchanged bool) {
if len(prevResultId) == 1 && dl.resultId == prevResultId[0] {
return []*ProtoDiagnostic{}, dl.resultId, true
}
return slices.Clone(dl.diagnostics), dl.resultId, false
}
func (dl *DiagnosticList) Clear() []*ProtoDiagnostic {
dl.lock.Lock()
defer dl.lock.Unlock()
prev := dl.diagnostics
dl.diagnostics = []*ProtoDiagnostic{}
dl.resetResultId()
return prev
}
func (dl *DiagnosticList) DeleteRelated(related RelatedInformation) {
dl.lock.Lock()
defer dl.lock.Unlock()
for i, diag := range dl.diagnostics {
if diag.Range == related.Range {
dl.diagnostics = slices.Delete(dl.diagnostics, i, i+1)
dl.resetResultId()
return
}
}
}
func (dl *DiagnosticList) Flush() ([]*ProtoDiagnostic, string, bool) {
dl.lock.Lock()
defer dl.lock.Unlock()
if !dl.dirty {
return []*ProtoDiagnostic{}, "", false
}
dl.dirty = false
return slices.Clone(dl.diagnostics), dl.resultId, true
}
// requires lock to be held in write mode
func (dl *DiagnosticList) resetResultId() {
dl.resultId = time.Now().Format(time.RFC3339Nano)
dl.dirty = true
}
type (
DiagnosticEvent int
ListenerFunc = func(path string, resultId string, diagnostics []*ProtoDiagnostic)
)
type DiagnosticHandler struct {
diagnosticsMu sync.RWMutex
diagnostics map[string]*DiagnosticList
listenerMu sync.RWMutex
listener ListenerFunc
}
func tagsForError(errWithPos reporter.ErrorWithPos) []protocol.DiagnosticTag {
err := errWithPos.Unwrap()
switch err.(type) {
case linker.ErrorUnusedImport:
return []protocol.DiagnosticTag{protocol.Unnecessary}
default:
return []protocol.DiagnosticTag{}
}
}
func severityForError(original protocol.DiagnosticSeverity, errWithPos reporter.ErrorWithPos) protocol.DiagnosticSeverity {
err := errWithPos.Unwrap()
switch err.(type) {
case linker.ErrorUnusedImport:
return protocol.SeverityWarning
default:
return original
}
}
func codeActionsForError(errWithPos reporter.ErrorWithPos) []CodeAction {
err := errWithPos.Unwrap()
pos := errWithPos.GetPosition()
switch err := err.(type) {
case linker.ErrorUnusedImport:
return []CodeAction{
{
Title: "Remove unused import",
Kind: protocol.SourceOrganizeImports,
Path: pos.Start().Filename,
IsPreferred: true,
Edits: []protocol.TextEdit{
{
// delete the line (column 0 of the current line to column 0 of the next line)
Range: protocol.Range{
Start: protocol.Position{
Line: uint32(pos.Start().Line - 1),
Character: 0,
},
End: protocol.Position{
Line: uint32(pos.End().Line), // the next line
Character: 0,
},
},
NewText: "",
},
},
},
}
case linker.ErrorUndeclaredName:
name := err.UndeclaredName()
if strings.Contains(name, ".") {
break
}
f := err.ParentFile()
tokens := f.Tokens()
eof, _ := tokens.Last()
last, _ := tokens.Previous(eof)
info := f.TokenInfo(last)
end := info.End()
// insert the new message between the last non-comment token and the EOF token
insertPos := protocol.Position{
Line: uint32(end.Line - 1),
Character: uint32(end.Col - 1),
}
textToInsert := fmt.Sprintf("\n\nmessage %s {\n \n}", name)
// figure out where to trigger a range selection, after the text would be inserted
revealRange := protocol.Range{
Start: protocol.Position{
Line: uint32(end.Line + 1), // 2 lines after the end of the last token
Character: 0, // column 0
},
End: protocol.Position{
Line: uint32(end.Line + 3),
Character: 1,
},
}
selectRange := protocol.Range{
Start: protocol.Position{
Line: uint32(end.Line + 2),
Character: 2,
},
End: protocol.Position{
Line: uint32(end.Line + 2),
Character: 2,
},
}
return []CodeAction{
{
Title: "Add definition for " + name + " in this file",
Kind: protocol.QuickFix,
Path: f.Name(),
Edits: []protocol.TextEdit{
{
Range: protocol.Range{
Start: insertPos,
End: insertPos,
},
NewText: textToInsert,
},
},
Command: NewSelectRangeCommand(SelectRangeParams{
SelectRange: selectRange,
RevealRange: revealRange,
}),
},
}
}
return []CodeAction{}
}
func metadataForError(errWithPos reporter.ErrorWithPos) map[string]string {
err := errWithPos.Unwrap()
switch err := err.(type) {
case linker.ErrorUnusedImport:
return map[string]string{
diagnosticKind: diagnosticKindUnusedImport,
"path": err.UnusedImport(),
}
case linker.ErrorUndeclaredName:
return map[string]string{
diagnosticKind: diagnosticKindUndeclaredName,
"name": err.UndeclaredName(),
"hint": err.Hint(),
}
}
return nil
}
func werrorCategoryForError(err error) string {
var xse parser.ExtendedSyntaxError
if errors.As(err, &xse) {
return xse.Category()
}
return ""
}
func relatedInformationForError(err error) []RelatedInformation {
var redeclared reporter.SymbolRedeclaredError
if ok := errors.As(err, &redeclared); ok {
return []RelatedInformation{
{
Range: redeclared.OtherDeclaration,
Message: "other declaration",
},
}
}
return nil
}
func (dr *DiagnosticHandler) getOrCreateDiagnosticListLocked(filename string) (dl *DiagnosticList, existing bool) {
dl, existing = dr.diagnostics[filename]
if !existing {
dl = &DiagnosticList{}
dr.diagnostics[filename] = dl
}
return
}
func (dr *DiagnosticHandler) HandleError(err reporter.ErrorWithPos) error {
if err == nil {
return nil
}
slog.Debug(fmt.Sprintf("[diagnostic] error: %s\n", err.Error()))
span := err.GetPosition()
var version int32
if info, ok := span.(ast.NodeInfo); ok {
version = info.Internal().ParentFile().GetVersion()
}
filename := span.Start().Filename
dr.diagnosticsMu.Lock()
dl, _ := dr.getOrCreateDiagnosticListLocked(filename)
dr.diagnosticsMu.Unlock()
newDiagnostic := &ProtoDiagnostic{
Path: filename,
Version: version,
Range: span,
Severity: protocol.SeverityError,
Error: err.Unwrap(),
Tags: tagsForError(err),
RelatedInformation: relatedInformationForError(err),
CodeActions: codeActionsForError(err),
Metadata: metadataForError(err),
}
dl.Add(newDiagnostic)
// dr.listenerMu.RLock()
// if dr.listener != nil {
// dr.listener(DiagnosticEventAdd, filename, version, newDiagnostic)
// }
// dr.listenerMu.RUnlock()
return nil // allow the compiler to continue
}
func (dr *DiagnosticHandler) HandleWarning(err reporter.ErrorWithPos) {
if err == nil {
return
}
slog.Debug(fmt.Sprintf("[diagnostic] warning: %s\n", err.Error()))
span := err.GetPosition()
var version int32
if info, ok := span.(ast.NodeInfo); ok {
version = info.Internal().ParentFile().GetVersion()
}
filename := span.Start().Filename
dr.diagnosticsMu.Lock()
dl, _ := dr.getOrCreateDiagnosticListLocked(filename)
dr.diagnosticsMu.Unlock()
newDiagnostic := &ProtoDiagnostic{
Path: filename,
Version: version,
Range: span,
Severity: severityForError(protocol.SeverityWarning, err),
Error: err.Unwrap(),
Tags: tagsForError(err),
CodeActions: codeActionsForError(err),
WerrorCategory: werrorCategoryForError(err),
RelatedInformation: relatedInformationForError(err),
Metadata: metadataForError(err),
}
dl.Add(newDiagnostic)
// dr.listenerMu.RLock()
// if dr.listener != nil {
// dr.listener(DiagnosticEventAdd, filename, version, newDiagnostic)
// }
// dr.listenerMu.RUnlock()
}
func (dr *DiagnosticHandler) GetDiagnosticsForPath(path string, prevResultId ...string) ([]*ProtoDiagnostic, string, bool) {
dr.diagnosticsMu.RLock()
defer dr.diagnosticsMu.RUnlock()
dl, ok := dr.diagnostics[path]
if !ok {
return []*ProtoDiagnostic{}, "", false
}
res, resultId, unchanged := dl.Get(prevResultId...)
slog.Debug(fmt.Sprintf("[diagnostic] querying diagnostics for %s: (%d results)\n", path, len(res)))
return res, resultId, unchanged
}
func (dr *DiagnosticHandler) FullDiagnosticSnapshot() map[string][]*ProtoDiagnostic {
dr.diagnosticsMu.RLock()
defer dr.diagnosticsMu.RUnlock()
res := make(map[string][]*ProtoDiagnostic, len(dr.diagnostics))
for path, dl := range dr.diagnostics {
list := make([]*ProtoDiagnostic, 0, len(dl.diagnostics))
for _, d := range dl.diagnostics {
list = append(list, &ProtoDiagnostic{
Path: d.Path,
Version: d.Version,
Range: d.Range,
Severity: d.Severity,
Error: d.Error,
Tags: d.Tags,
RelatedInformation: d.RelatedInformation,
CodeActions: d.CodeActions,
Metadata: d.Metadata,
WerrorCategory: d.WerrorCategory,
})
}
res[path] = list
}
return res
}
func (dr *DiagnosticHandler) ClearDiagnosticsForPath(path string) {
dr.diagnosticsMu.Lock()
defer dr.diagnosticsMu.Unlock()
var prev []*ProtoDiagnostic
if dl, ok := dr.diagnostics[path]; ok {
prev = dl.Clear()
}
slog.Debug(fmt.Sprintf("[diagnostic] clearing %d diagnostics for %s\n", len(prev), path))
// var version int32
// if len(prev) > 0 {
// version = prev[len(prev)-1].Version
// }
// dr.listenerMu.RLock()
// if dr.listener != nil {
// dr.listener(DiagnosticEventClear, path, version, prev...)
// }
// also clear any diagnostics that may be linked as related information
for _, d := range prev {
for _, rel := range d.RelatedInformation {
other, ok := dr.diagnostics[rel.Range.Start().Filename]
if !ok {
continue
}
other.DeleteRelated(rel)
}
}
// dr.listenerMu.RUnlock()
}
func (dr *DiagnosticHandler) Stream(ctx context.Context, callback ListenerFunc) {
// dr.diagnosticsMu.RLock()
dr.listenerMu.Lock()
dr.listener = callback
dr.listenerMu.Unlock()
// dr.listenerMu.RLock()
// for path, dl := range dr.diagnostics {
// callback(path, dl.resultId, dl.diagnostics)
// }
// dr.listenerMu.RUnlock()
// dr.diagnosticsMu.RUnlock()
<-ctx.Done()
dr.listenerMu.Lock()
dr.listener = nil
dr.listenerMu.Unlock()
}
func (dr *DiagnosticHandler) Flush() {
dr.diagnosticsMu.Lock()
defer dr.diagnosticsMu.Unlock()
for path, dl := range dr.diagnostics {
diagnostics, resultId, wasDirty := dl.Flush()
if wasDirty {
slog.Debug(fmt.Sprintf("[diagnostic] flushing %d diagnostics for %s\n", len(diagnostics), path))
dr.listenerMu.RLock()
if dr.listener != nil {
dr.listener(path, resultId, diagnostics)
}
dr.listenerMu.RUnlock()
}
}
}