Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppVeyor integration #15

Closed
limonte opened this issue May 27, 2018 · 3 comments
Closed

AppVeyor integration #15

limonte opened this issue May 27, 2018 · 3 comments

Comments

@limonte
Copy link

limonte commented May 27, 2018

From https://engineering.videoblocks.com/these-four-clean-code-tips-will-dramatically-improve-your-engineering-teams-productivity-b5bd121dd150

“If it isn’t tested, it’s broken”

There are tests, but you're not running them anywhere and users can't be sure that the polyfill tests are passing. AppVeyor is the default solution for IE tests.
@limonte limonte closed this as completed Jul 25, 2018
@kumarharsh
Copy link
Collaborator

@limonte I've added the tests in my fork - they'll be added here soon.

@limonte limonte reopened this Jul 25, 2018
@limonte
Copy link
Author

limonte commented Jul 25, 2018 •
edited
Loading

Great! I will reopen this issue then :)

@kumarharsh
Copy link
Collaborator

Completed the integration and published to https://npmjs.com/package/custom-event-polyfill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumarharsh @limonte