Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolinking not working like GFM #17

Open
0xdevalias opened this issue Jul 21, 2020 · 3 comments
Open

Autolinking not working like GFM #17

0xdevalias opened this issue Jul 21, 2020 · 3 comments

Comments

@0xdevalias
Copy link

In GFM we can have URL's automatically turned into links without requiring any special formatting around them, yet this doesn't seem to be possible with this library. With the closest solution seeming to be:

It seems this has been noticed in other projects as well, eg.:

@timdiggins
Copy link

I started on this with approach of making rinku an optional dependency as per ancient comment in gettalong/kramdown#306, and how I deal with this in other projects: Rinku.auto_link(Kramdown::Document.new(source, input: "GFM").to_html).html_safe.

I have got a test harness for this (with different gemfiles and different testcases), but when trying to implement it I can't see any way of hooking into the Kramdown::Converter::Html from here -- maybe because this is genuinely just a parser? Is the idea of just using rinku (which would be super fast, and independently tested) no longer applicable?

Any suggestions @ashmaroli @gettalong ?

@timdiggins
Copy link

timdiggins commented Mar 14, 2021

FYI here is my test harness timdiggins@dc74432

@adoyle-h
Copy link

adoyle-h commented Feb 8, 2023

@ashmaroli @gettalong Can you help to fix this issue? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants