Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong naming of resoureces in generated roles and clusterroles #54

Closed
matteogastaldello opened this issue Jul 26, 2024 · 0 comments · Fixed by #55
Closed

Wrong naming of resoureces in generated roles and clusterroles #54

matteogastaldello opened this issue Jul 26, 2024 · 0 comments · Fixed by #55
Assignees

Comments

@matteogastaldello
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
 creationTimestamp: "2024-07-23T12:37:29Z"
 name: powerbi
 resourceVersion: "89740346"
 uid: 38e2c328-9984-4680-b4bf-23c9f58ab9e3
rules:
- apiGroups:
 - ""
 resources:
 - namespaces
 verbs:
 - get
 - list
 - watch
 - create
- apiGroups:
 - jira.krateo.io
 resources:
 - ticketjiras
 verbs:
 - '*'
- apiGroups:
 - powerbi.krateo.io
 resources:
 - pipelinepbis
 verbs:
 - '*'
- apiGroups:
 - powerbi.krateo.io
 resources:
 - workspaces
 verbs:
 - '*'
- apiGroups:
 - powerbi.krateo.io
 resources:
 - workspacecheckers
 verbs:
 - '*'

Here the resources named “pipelinepbis” and “ticketjiras” are not correct. The correct plural defined for these CRD are “pipelinespbi” and “ticketsjira”.

The problem is due the assumption that pluralization from Kind with Pluralise function of the fleet library would cover all the cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant