Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

chore(*): Updates to latest k8s openapi and kube #49

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

thomastaylor312
Copy link
Contributor

This partially reverts commit 357f4ad.
The k8s openapi crate reverted their change to remove Option wrapped
collections and so this will be another breaking change and new version
bump for krator

Copy link
Member

@kflansburg kflansburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one type on the docs


```toml
[dependencies.k8s-openapi]
version = "0.12"
version = "0.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this version and the k8s version mentioned below are wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is. I'll push a fix

@kflansburg
Copy link
Member

@thomastaylor312 By my reading of

Note: The line and column numbers for --> lines pointing to the test are not normalized, and left as-is. 

this only applies to test files, and never to file paths. I believe we should be able to do this in theory:

note: required by `Transition::<S>::next`
  --> $SRC_DIR/src/state.rs:LL:CC
   |
LL | /     pub fn next<I: State<S>, O: State<S>>(_i: Box<I>, o: O) -> Transition<S>
LL | |     where
LL | |         I: TransitionTo<O>,
   | |___________________________^

My guess is that the new clarifying output that they added is not being passed through normalization somehow. I have opened a bug report to have someone look at it: rust-lang/rust#88819

@thomastaylor312
Copy link
Contributor Author

Yeah I did try to do the SRC_DIR thing and it didn't work. So I'll follow that rust issue

@thomastaylor312
Copy link
Contributor Author

Oh and I did try the -Z ui-testing thing in the comment at the top of a file, but that didn't seem to help. Maybe I am doing that wrong

olivierlemasle added a commit to olivierlemasle/krustlet that referenced this pull request Sep 14, 2021
As k8s-openapi reverted in
Arnavion/k8s-openapi@f0fda04
to its use of Option<>, this commit reverts most of
4846df7.

Also update kube and kube-runtime to 0.60.
! This depends on krator PR: krator-rs/krator#49 !

Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
This partially reverts commit 357f4ad.
The k8s openapi crate reverted their change to remove `Option` wrapped
collections and so this will be another breaking change and new version
bump for krator

Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
@thomastaylor312 thomastaylor312 merged commit f158936 into krator-rs:main Sep 27, 2021
@thomastaylor312 thomastaylor312 deleted the chore/k8s_openapi branch September 27, 2021 22:05
olivierlemasle added a commit to olivierlemasle/krustlet that referenced this pull request Oct 1, 2021
As k8s-openapi reverted in
Arnavion/k8s-openapi@f0fda04
to its use of Option<>, this commit reverts most of
4846df7.

Also update kube and kube-runtime to 0.60.
! This depends on krator PR: krator-rs/krator#49 !

Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
thomastaylor312 pushed a commit to krustlet/oci-distribution that referenced this pull request Mar 2, 2023
As k8s-openapi reverted in
Arnavion/k8s-openapi@f0fda04
to its use of Option<>, this commit reverts most of
88390c7.

Also update kube and kube-runtime to 0.60.
! This depends on krator PR: krator-rs/krator#49 !

Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants