-
Notifications
You must be signed in to change notification settings - Fork 14
chore(*): Updates to latest k8s openapi and kube #49
chore(*): Updates to latest k8s openapi and kube #49
Conversation
78a9071
to
5d8a648
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one type on the docs
docs/community/developers.md
Outdated
|
||
```toml | ||
[dependencies.k8s-openapi] | ||
version = "0.12" | ||
version = "0.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this version and the k8s version mentioned below are wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is. I'll push a fix
f1950db
to
3229d43
Compare
@thomastaylor312 By my reading of
this only applies to test files, and never to file paths. I believe we should be able to do this in theory: note: required by `Transition::<S>::next`
--> $SRC_DIR/src/state.rs:LL:CC
|
LL | / pub fn next<I: State<S>, O: State<S>>(_i: Box<I>, o: O) -> Transition<S>
LL | | where
LL | | I: TransitionTo<O>,
| |___________________________^ My guess is that the new clarifying output that they added is not being passed through normalization somehow. I have opened a bug report to have someone look at it: rust-lang/rust#88819 |
Yeah I did try to do the |
Oh and I did try the |
As k8s-openapi reverted in Arnavion/k8s-openapi@f0fda04 to its use of Option<>, this commit reverts most of 4846df7. Also update kube and kube-runtime to 0.60. ! This depends on krator PR: krator-rs/krator#49 ! Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
This partially reverts commit 357f4ad. The k8s openapi crate reverted their change to remove `Option` wrapped collections and so this will be another breaking change and new version bump for krator Signed-off-by: Taylor Thomas <taylor.thomas@microsoft.com>
3229d43
to
63579a4
Compare
Signed-off-by: Taylor Thomas <taylor@oftaylor.com>
As k8s-openapi reverted in Arnavion/k8s-openapi@f0fda04 to its use of Option<>, this commit reverts most of 4846df7. Also update kube and kube-runtime to 0.60. ! This depends on krator PR: krator-rs/krator#49 ! Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
As k8s-openapi reverted in Arnavion/k8s-openapi@f0fda04 to its use of Option<>, this commit reverts most of 88390c7. Also update kube and kube-runtime to 0.60. ! This depends on krator PR: krator-rs/krator#49 ! Signed-off-by: Olivier Lemasle <olivier.lemasle@apalia.net>
This partially reverts commit 357f4ad.
The k8s openapi crate reverted their change to remove
Option
wrappedcollections and so this will be another breaking change and new version
bump for krator