Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

update rust version #67

Closed
wants to merge 3 commits into from
Closed

update rust version #67

wants to merge 3 commits into from

Conversation

spencergilbert
Copy link
Contributor

Hi! I started poking around krator and ran into a few issues with the Rust version and the UI tests. This should resolve them, and I fixed the naming of the CI steps noted here: #51 (comment)

  • Update and pin rust to 1.60, reblessing UI tests
  • Fix step names for UI test job

Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
Copy link
Member

@kflansburg kflansburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the update to 1.60. I'm not sure that we want to pin the Rust version though, we've historically tried to always support stable. Based on rustup Docs, it seems like pinning is a special case, rather than best practice.

@spencergilbert
Copy link
Contributor Author

Appreciate the update to 1.60. I'm not sure that we want to pin the Rust version though, we've historically tried to always support stable. Based on rustup Docs, it seems like pinning is a special case, rather than best practice.

Cool - I'll roll that back and mess with the tests again, they were fine locally but I'm not super familiar with the compiled tests there.

I was also looking at upgrading deps, particularly kube to get token rotation support - if y'all are interested in upgrading some/all of the crates.

Signed-off-by: Spencer Gilbert <spencer.gilbert@gmail.com>
@spencergilbert spencergilbert changed the title spencergilbert/update and pin rust update rust version Apr 13, 2022
@kflansburg
Copy link
Member

Cool - I'll roll that back and mess with the tests again, they were fine locally but I'm not super familiar with the compiled tests there.

I was also looking at upgrading deps, particularly kube to get token rotation support - if y'all are interested in upgrading some/all of the crates.

Thanks. Would definitely be interested in a kube upgrade.

@spencergilbert spencergilbert mentioned this pull request Apr 13, 2022
@kflansburg
Copy link
Member

Changes included in #68

@kflansburg kflansburg closed this Apr 14, 2022
@spencergilbert spencergilbert deleted the spencergilbert/update-and-pin-rust branch April 14, 2022 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants