Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vanillajs-keyed "replace all rows" baseline is wrong #103

Closed
leeoniya opened this issue Dec 20, 2016 · 1 comment
Closed

vanillajs-keyed "replace all rows" baseline is wrong #103

leeoniya opened this issue Dec 20, 2016 · 1 comment

Comments

@leeoniya
Copy link
Contributor

leeoniya commented Dec 20, 2016

@krausest

vanillajs-keyed doesnt actually replace rows for "replace all rows", which is why it's so fast while other keyed implementations are slower. at least for the keyed version, it needs to do the correct thing (which should clock in at slightly faster than the kivi impl)

i made a DOM-instrumented version of of vanillajs-keyed [1] [2]. you can watch the console to see a summary of DOM ops performed for any action.

feel free to use my DOMInstr lib (it's MIT) to check what the other implementations do when porting to keyed versions.

[1] https://rawgit.com/leeoniya/js-framework-benchmark/vanillajs-keyed-instrumented/vanillajs-keyed/index.html
[2] leeoniya@8f1acaa

@krausest
Copy link
Owner

krausest commented Jan 9, 2017

Thanks. Fixed in 93c57f7.

@krausest krausest closed this as completed Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants