Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub-optimal "append rows to large table" in vanillajs (keyed and non-keyed) #110

Closed
leeoniya opened this issue Jan 14, 2017 · 2 comments
Closed

sub-optimal "append rows to large table" in vanillajs (keyed and non-keyed) #110

leeoniya opened this issue Jan 14, 2017 · 2 comments

Comments

@leeoniya
Copy link
Contributor

leeoniya commented Jan 14, 2017 •
edited
Loading

@krausest kivi and inferno score non-trivially better than vanillajs in "append rows to large table" for both keyed and non-keyed impls. something to look into.
@krausest
Copy link
Owner

Directly appending the tr to the table is faster than using document.createDocumentFragment() - fixed now.

@leeoniya
Copy link
Contributor Author

🎉

yeah, createDocumentFragement optimizations are soooo 2012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leeoniya @krausest