Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you add port # as an option? #1

Closed
travisghansen opened this issue Sep 19, 2016 · 7 comments
Closed

Can you add port # as an option? #1

travisghansen opened this issue Sep 19, 2016 · 7 comments
Assignees

Comments

@travisghansen
Copy link

travisghansen commented Sep 19, 2016

One of my receivers uses port 49154 as the port for desc.xml Any chance that can become a config option on a per-receiver basis?

Also, due to the failed web-request node red completely dies so it probably needs a bit more bullet-proofing in place:

19 Sep 03:48:20 - TypeError: Cannot read property 'root' of null
    at /data/node_modules/node-red-contrib-avr-yamaha/avr-yamaha.js:248:36
    at Parser.<anonymous> (/data/node_modules/node-red-contrib-avr-yamaha/node_modules/xml2js/lib/xml2js.js:489:18)
    at emitOne (events.js:77:13)
    at Parser.emit (events.js:169:7)
    at Parser.exports.Parser.Parser.parseString (/data/node_modules/node-red-contrib-avr-yamaha/node_modules/xml2js/lib/xml2js.js:499:16)
    at Parser.parseString (/data/node_modules/node-red-contrib-avr-yamaha/node_modules/xml2js/lib/xml2js.js:7:59)
    at exports.parseString (/data/node_modules/node-red-contrib-avr-yamaha/node_modules/xml2js/lib/xml2js.js:540:19)
    at IncomingMessage.<anonymous> (/data/node_modules/node-red-contrib-avr-yamaha/avr-yamaha.js:242:15)
    at emitNone (events.js:72:20)
    at IncomingMessage.emit (events.js:166:7)
    at endReadableNT (_stream_readable.js:921:12)
    at nextTickCallbackWith2Args (node.js:442:9)
    at process._tickCallback (node.js:356:17)
@krauskopf
Copy link
Owner

Thanks for the feedback.

Please have a look at version 0.6.0

@krauskopf krauskopf self-assigned this Sep 19, 2016
@travisghansen
Copy link
Author

Cool I'll try it out a bit later and let you know how it works. I've got a mix of models so it should be a good test. Thanks!

@travisghansen
Copy link
Author

This is good:

19 Sep 17:36:00 - [info] [avr-yamaha:34d7823d.26ce4e] Failed to get device description with error: Error: connect ECONNREFUSED 172.29.50.122:8080

I've got the node updated with the appropriate port and it worked great. I'll add the others on my network to the mix and report back just to make sure there's not something crazy going on with multiples.

@travisghansen
Copy link
Author

That seems to work. Thanks!

@krauskopf
Copy link
Owner

Thanks for testing. Do you mind listing the model types, that you used? Would be helpfull to have a list of verified models.

@travisghansen
Copy link
Author

travisghansen commented Sep 25, 2016

Here are the models I have:

  • TSR-5790 (this is the one with the strange port #)
  • RX-A740
  • HTR-4065

@krauskopf
Copy link
Owner

Thx! Added the models to readme. Might be useful for other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants