Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run lint #61

Closed
emilos opened this issue Mar 9, 2020 · 5 comments
Closed

npm run lint #61

emilos opened this issue Mar 9, 2020 · 5 comments

Comments

@emilos
Copy link

emilos commented Mar 9, 2020

It would be nice to have a npm run lint script in package.json that would let you to use the default linter/prettifier. Right now it's not obvious how to run it.

@emilos
Copy link
Author

emilos commented Mar 10, 2020

Step 1: install

npm install standard

Step 2: add lint to package.json (scripts section)

"lint": "standard"

Step 3: autofixes

npm run lint -- --fix

Step 4: manual fixes

@zaiste
Copy link
Collaborator

zaiste commented Mar 11, 2020

@emilos I've just realized I've configured here eslint with eslint:recommended. Would that be enough for starters ?

@emilos
Copy link
Author

emilos commented Mar 11, 2020

anything works for now I guess

@zaiste
Copy link
Collaborator

zaiste commented Mar 11, 2020

@emilos I've improved the current ESLint configuration along with Prettier, but for some strange reason the singleQuote option is not being taken account. The explainer.js line 20 is a good example of that. I'm not sure how to resolve it.

@emilos
Copy link
Author

emilos commented Mar 11, 2020

@zaiste I'm not sure, it's probably not worth investigating now :) I'll just close this given it's much better now

@emilos emilos closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants