Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override entrypoint in docker_service resource #59

Closed
mavogel opened this issue Dec 25, 2020 · 3 comments · Fixed by #244
Closed

Override entrypoint in docker_service resource #59

mavogel opened this issue Dec 25, 2020 · 3 comments · Fixed by #244
Assignees
Labels
enhancement New feature or request r/service Relates to the service resource
Milestone

Comments

@mavogel
Copy link
Contributor

mavogel commented Dec 25, 2020

This issue was originally opened by @b4nst as hashicorp/terraform-provider-docker#261. It was migrated here as a result of the community provider takeover from @kreuzwerker. The original body of the issue is below.


Terraform Version

Terraform v0.12.24

  • provider.docker v2.7.0

Affected Resource(s)

  • docker_service

Expected Behavior

Resource accept entrypoint option, as specified in docker service_create doc

Actual Behavior

Resource does not accept an entrypoint option

@mavogel mavogel added bug Something isn't working r/service Relates to the service resource labels Dec 25, 2020
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this issue to be closed, please set the label pinned.

@github-actions github-actions bot added the stale label Mar 29, 2021
@github-actions github-actions bot closed this as completed Apr 6, 2021
@mavogel mavogel removed the stale label Apr 7, 2021
@mavogel mavogel reopened this Apr 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.
If you don't want this issue to be closed, please set the label pinned.

@github-actions github-actions bot added the stale label Jun 6, 2021
@mavogel mavogel removed the stale label Jun 14, 2021
@mavogel mavogel added this to the v2.14.0 milestone Jun 23, 2021
@mavogel mavogel added enhancement New feature or request and removed bug Something isn't working labels Jun 23, 2021
@mavogel
Copy link
Contributor Author

mavogel commented Jun 27, 2021

AFAICS in the cli v20.10.7 the entrypoint flag of the cli is passed to the command property of the ServiceSpec -> TaskSpec -> ContainerSpec, see here https://github.com/docker/cli/blob/v20.10.7/cli/command/service/opts.go#L705

We actually do support this already by the command attribute. We could

  1. add an entrypoint attribute, let it conflict with the command. Then deprecate and remove the command in v3.0.0.
  2. or update the documentation only

@suzuki-shunsuke WDYT?

@mavogel mavogel self-assigned this Jul 7, 2021
@mavogel mavogel linked a pull request Jul 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request r/service Relates to the service resource
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant