Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needed some explanations in Readme.md #6

Open
mkikets99 opened this issue May 11, 2022 · 3 comments
Open

needed some explanations in Readme.md #6

mkikets99 opened this issue May 11, 2022 · 3 comments

Comments

@mkikets99
Copy link

First: need to fix a phrase sudo ./build.sh to sudo ./mylfs.sh
Second: there is an error at the beginning when it not creating pkgs folder.
Third: it would be perfect if there was a table with Phases and Instructions for some people. This will allow to analyse more on which phase do what.

@mkikets99
Copy link
Author

Also... i saw that a lot of code from ./build.sh is missing in ./mylfs.sh
Did someone accidentally removed it?

@mkikets99
Copy link
Author

ok i saw that uefi was removed in 09894e4788d85bcd47c2aca98ac93b14530ebcec
Ill be playing with making in on a VM

@krglaws
Copy link
Owner

krglaws commented May 12, 2022

First: need to fix a phrase sudo ./build.sh to sudo ./mylfs.sh

Yes, I renamed build.sh to mylfs.sh a couple weeks ago.

Second: there is an error at the beginning when it not creating pkgs folder.

Oof, good catch. I removed the pkgs/ dir from the repo because I decided it was kinda dumb to have an empty directory in it. I forgot to test to make sure that it creates the directory at runtime though. I'll get that fixed.

Third: it would be perfect if there was a table with Phases and Instructions for some people. This will allow to analyse more on which phase do what.

Hmm, well I figure that's what the README and the actual LFS book is for. People using this script should really be well versed in how the LFS build works already. The README describes how phase1 roughly corresponds to chapter 5, phase2 chapter 6, etc. But if you think there should be more info, you can submit a PR so I see what you mean.

And I did indeed remove the UEFI capability altogether because I could not get it to boot from a flash drive (BIOS boot works fine). It would be cool to have that option down the line, but for now I abandoned it. If you manage to get it working, that would be sick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants