Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VK_ERROR_MEMORY_MAP_FAILED on radv #25

Closed
ChristophHaag opened this issue Jan 22, 2018 · 2 comments
Closed

VK_ERROR_MEMORY_MAP_FAILED on radv #25

ChristophHaag opened this issue Jan 22, 2018 · 2 comments

Comments

@ChristophHaag
Copy link

Weird that nobody has made an issue yet because it has long been known to be broken

$ vkcube                                                                                                                                                                  
WARNING: radv is not a conformant vulkan implementation, testing use only.
1 physical devices
vendor id 1002, device name AMD RADV POLARIS10 (LLVM 7.0.0)
../src/amd/vulkan/radv_device.c:2359: VK_ERROR_MEMORY_MAP_FAILED
[1]    28927 segmentation fault (core dumped)  vkcube

Relevant upstream issue: https://bugs.freedesktop.org/show_bug.cgi?id=100951#c2

vkcube is known broken, it allocates memory from a non-mappable memory type and then tries to map it.

@krh
Copy link
Owner

krh commented Jan 22, 2018

Thanks for filing the issue, I wasn't aware of this. It's not entirely surprising either, since we just pick the first memory type. Just before the call to vkAllocateMemory in cube.c we should probably look through the kinds of memory in reqs.memoryTypeBits and pick one that supports mapping. If there isn't one, we'll need to use staging buffers, which will be more work.

@ChristophHaag
Copy link
Author

ChristophHaag commented May 15, 2018

fixed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants