Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core logic - Add user authentication feature #37

Open
krishnaacharyaa opened this issue Oct 31, 2023 · 4 comments
Open

core logic - Add user authentication feature #37

krishnaacharyaa opened this issue Oct 31, 2023 · 4 comments
Labels
enhancement Enhancement to the existing code

Comments

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Oct 31, 2023

#38 needs to be solved before started this
This would be a big feature, presently we are not supporting, we can plan google and github for now, if feasible even twitter login we have to make sure we add test cases for this, to ensure this is working perfectly in all scenarios, this should use appropriate state management preferably context api for now or any other simple management.

This story should cover proper rendering of UI elements based on the user logged in state, and the functionality of logout also to be handled. Updation and deletion of post will be handled in another user story

@krishnaacharyaa krishnaacharyaa added the enhancement Enhancement to the existing code label Oct 31, 2023
@krishnaacharyaa krishnaacharyaa added this to the user-authentication milestone Oct 31, 2023
@SanjeevKrSingh
Copy link

Hey @krishnaacharyaa Is anyone doing this? If not could you please assign this to me.

@krishnaacharyaa
Copy link
Owner Author

Sure, but we are planning to focus on the testing first, can you look into integration testing of backend and frontend? or unit tests of frontend? That would be really great, Post these, we can take up this :)

@namancoder
Copy link

Hey @krishnaacharyaa , can i pick this up?

@krishnaacharyaa
Copy link
Owner Author

krishnaacharyaa commented Dec 3, 2023

@namancoder and for everyone in general who want to pick this up, thank you for your interest, but we'll take up this once we complete this milestone Securing the application with test cases

Why are we doing this?
User Auth is a considerably a good big feature for this project at this stage, and we don't want to push it without the test cases and covering all the corner cases, so we will take this up as soon as the above issues are resolved, feel free to explore the integration testing and snapshot testing, the faster we achieve this milestone, the faster we can get started with this :)

Once the milestone is completed, we should ideally focus on #38, first only after that gets merged, we'll take this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the existing code
Projects
None yet
Development

No branches or pull requests

3 participants