This repository has been archived by the owner on May 8, 2022. It is now read-only.
Make the async APIs completely parallel #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the point of coordination introduced in a9c2f5b when making the APIs thread-safe, by changing the updates to the result array from `sync` to `async`.
This was referenced May 16, 2020
The parallel batches don’t need to combine their results with every new result, only when each batch finishes. This is simpler and should probably optimize the performance of the queues used to combine results, too.
|
Thanks @krisk! Mind publishing a new version? |
LambdaDigamma
pushed a commit
to LambdaDigamma/fuse-swift
that referenced
this pull request
Apr 28, 2021
* Make the async APIs completely parallel This removes the point of coordination introduced in a9c2f5b when making the APIs thread-safe, by changing the updates to the result array from `sync` to `async`. * Simplify and optimize the async APIs The parallel batches don’t need to combine their results with every new result, only when each batch finishes. This is simpler and should probably optimize the performance of the queues used to combine results, too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the point of coordination introduced in
a9c2f5b when making the APIs
thread-safe, by changing the updates to the result array from
synctoasync.