Skip to content
This repository has been archived by the owner on Dec 28, 2020. It is now read-only.

Update material version and fixed name of code #35

Merged

Conversation

vincenzopalazzo
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo commented Apr 5, 2020

I try to compile this code with my IDE (IntelliJ) and don't work, I renamed the name of the file in ts to tcf and now walks.

I have a very small question, why you using the text file and don't and xml or a propriety file?

Have a good weekend

@krissh-the-dev
Copy link
Owner

Hi there, thanks for your help. I really appreciate it. I had already changed the file extension yesterday (in my country) ~ 16 hours ago. I wonder why you didn't get the recent changes.. Did I forget to push my commits...? Will check it out.

I've gone with plain text for the configurations, so that it'll be readable by users with absolutely no programming knowledge. In case someone messes up with configurations.. (The options in configurations aren't highly stable and reliable yet) and can't open the editor anymore, they can easily change the values in the file themselves.

I'm glad that tried my project. I'm looking forward to make a new release this weekend. I'll be fixing many bugs with configurations. Can I ask you some help when needed?
Thanks again.

@vincenzopalazzo
Copy link
Collaborator Author

Hi @Krishnamoorthy12,

I noted that you have lost something, a file with extension .ts is very strange :)

I like your project because is very cool with swing, It is a game :) and I like the games.

But I want to add also more details:

I've gone with plain text for the configurations, so that it'll be readable by users with absolutely no programming knowledge. In case someone messes up with configurations.. (The options in configurations aren't highly stable and reliable yet) and can't open the editor anymore, they can easily change the values in the file themselves.

I think the existing solution better, like file proprieties, you image this configuration:

THEME=MATERIAL_DARK
SPACE=4

It is more configurable than the file proprieties.

Can I ask you some help when needed?

Absolutely, you can create a slack workspace, if you want.

(The options in configurations aren't highly stable and reliable yet)

I see I think the Configuration class can be improved

@krissh-the-dev
Copy link
Owner

krissh-the-dev commented Apr 5, 2020

I noted that you have lost something, a file with extension .ts is very strange :)

Yes, you're 100% right. And that's why I changed it to tcf (Abbr. Trident Configuration File)

I like your project because is very cool with swing, It is a game :) and I like the games.

Game??? 😳 You mean you like to swing? 😹😹 I like it too.

I think the existing solution better, like file proprieties, you image this configuration:

THEME=MATERIAL_DARK
SPACE=4

You're right. I'll try to make it possible. But it'll involve some more work.

@vincenzopalazzo
Copy link
Collaborator Author

@Krishnamoorthy12

Game??? flushed You mean you like to swing? joy_catjoy_cat I like it too.

Yes create an editor text with sublime with a very cool game, right? :)

You're right. I'll try to make it possible. But it'll involve some more work.

I can help you to refactoring the class if you want

@krissh-the-dev
Copy link
Owner

That'll be great. I have just created a slack account. I'm learning to use it.. will try to join there asap.

@vincenzopalazzo
Copy link
Collaborator Author

@Krishnamoorthy12 can add me with the my dev mail vincenzopalazzodev@gmail.com

@krissh-the-dev
Copy link
Owner

Dependency update:

material-swing

@krissh-the-dev krissh-the-dev reopened this Apr 5, 2020
@krissh-the-dev krissh-the-dev merged commit badefa5 into krissh-the-dev:maven-master Apr 5, 2020
@krissh-the-dev krissh-the-dev linked an issue Apr 5, 2020 that may be closed by this pull request
@krissh-the-dev
Copy link
Owner

I think the existing solution better, like file proprieties, you image this configuration:

THEME=MATERIAL_DARK
SPACE=4

Partially implemented: f746764 and tested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception with some resources inside the file
2 participants