Fix kfcgi fixedpool SIGHUP handling #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfcgi is supposed to restart workers on receipt of SIGHUP, but exits instead. The problem occurs because terminating workers triggers SIGCHLD, which causes kfcgi to terminate.
kristapsdz
pushed a commit
that referenced
this pull request
Apr 19, 2016
when we next re-enter the wait loop. (In fixed pool mode.) This from a modified patch #3 by https://github.com/cornett -- thanks so much!
kristapsdz
pushed a commit
that referenced
this pull request
Apr 19, 2016
…, it was printing the wrong message. This does not change any functionality beyond that. From part of a patch in #3 by https://github.com/cornett -- thanks!
|
Great catch! I merged this as two patches, as they're two different issues. |
kristapsdz
pushed a commit
that referenced
this pull request
Jan 16, 2018
when we next re-enter the wait loop. (In fixed pool mode.) This from a modified patch #3 by https://github.com/cornett -- thanks so much!
kristapsdz
pushed a commit
that referenced
this pull request
Jan 16, 2018
…, it was printing the wrong message. This does not change any functionality beyond that. From part of a patch in #3 by https://github.com/cornett -- thanks!
kristapsdz
pushed a commit
that referenced
this pull request
Jan 20, 2018
when we next re-enter the wait loop. (In fixed pool mode.) This from a modified patch #3 by https://github.com/cornett -- thanks so much!
kristapsdz
pushed a commit
that referenced
this pull request
Jan 20, 2018
…, it was printing the wrong message. This does not change any functionality beyond that. From part of a patch in #3 by https://github.com/cornett -- thanks!
kristapsdz
added a commit
that referenced
this pull request
Mar 31, 2020
when we next re-enter the wait loop. (In fixed pool mode.) This from a modified patch #3 by https://github.com/cornett -- thanks so much!
kristapsdz
added a commit
that referenced
this pull request
Mar 31, 2020
…, it was printing the wrong message. This does not change any functionality beyond that. From part of a patch in #3 by https://github.com/cornett -- thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kfcgi is supposed to restart workers on receipt of SIGHUP, but exits
instead. The problem occurs because terminating workers triggers
SIGCHLD, which causes kfcgi to terminate.