-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting color through fill prop not working properly on 0.14.1 #64
Comments
Yeah 0.14 enabled SVGO, which in theory does not mean breaking changes, but in reality it did break things. |
@ptfly Could you please provide a full example to reproduce the bug? I tried to reproduce the bug, but wasn't able to do it because probably I'm not doing exactly what you are doing. |
There is nothing more then the code above. I just removed the path for readability sake. Could be my SVGs, but they are quite standard. Here is an example icon:
I'm using them like that:
Then |
Alright, I'll try to reproduce with that example. |
@ptfly I managed to reproduce the bug, so I released a fix in 0.14.3. Could you please try it out and see if it fixes the issue for you? |
Yes, now it looks fine! Thanks for the fix! |
Using fill on svgs containing groups
<g>
withfill="none"
and actual fill color set deeper in the tree doesn't work. In order to make it work, I have to set the fill color on the top most group.This will work:
But this wont:
On 0.13 its is working fine! Is there any breaking change which is not mentioned?
The text was updated successfully, but these errors were encountered: