Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint-config-recommended to 5.0 #67

Conversation

tysongach
Copy link

Changelog: https://github.com/stylelint/stylelint-config-recommended/blob/master/CHANGELOG.md#500

I’ve also run npm audit fix in a separate commit to fix 7 vulnerabilities.

@tysongach
Copy link
Author

@kristerkari 👋 Hello! Any chance of a review on this? Thanks.

@fgblomqvist
Copy link

fgblomqvist commented Jun 8, 2021

You also have to disable no-invalid-position-at-import-rule when updating, because it was turned on in 5.0.0.
See: stylelint/stylelint#5322

Otherwise you will have a non-working lint config.

@kristerkari
Copy link
Collaborator

Alright, I'll create a new PR that both updates stylelint-config-recommended and disables no-invalid-position-at-import-rule rule.

@tysongach
Copy link
Author

Thanks @kristerkari!

@kristerkari
Copy link
Collaborator

Thanks for the contribution @tysongach !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants