Merge pull request #393 from kristerkari/bugfix/at-rule-conditional-n…

…o-parentheses-ignore-function-calls

at-rule-conditional-no-parentheses: don't warn for function calls

CHANGELOG.md

@@ -1,5 +1,6 @@
 # HEAD
 
+- Fixed: `at-rule-conditional-no-parentheses` don't warn for function calls.
 - Fixed: `map-keys-quotes` ignore math operators inside map values.
 - Fixed: `operator-no-unspaced` was looking for operators inside `@forward` and `@use`.
 

src/rules/at-rule-conditional-no-parentheses/__tests__/index.js

@@ -1,4 +1,4 @@
-import rule, { ruleName, messages } from "..";
+import rule, { messages, ruleName } from "..";
 
 testRule(rule, {
   ruleName,
@@ -29,6 +29,33 @@ testRule(rule, {
       @else if true {}
       @else {}`,
       description: "accepts @else unconditionally"
+    },
+    {
+      code: `
+      @function strip-unit($number) {
+        @if type-of($number) == "number" and not unitless($number) {
+          @return $number / ($number * 0 + 1);
+        }
+
+        @return $number;
+      }
+      `,
+      description: "accepts function calls using @if"
+    },
+    {
+      code: `
+      @function strip-unit($number) {
+        @if true {
+          @return $number;
+        }
+        @else if type-of($number) == "number" and not unitless($number) {
+          @return $number / ($number * 0 + 1);
+        }
+
+        @return $number;
+      }
+      `,
+      description: "accepts function calls using @else if"
     }
   ],
 

src/rules/at-rule-conditional-no-parentheses/index.js

@@ -1,6 +1,6 @@
+import _ from "lodash";
 import { utils } from "stylelint";
 import { namespace } from "../../utils";
-import _ from "lodash";
 
 export const ruleName = namespace("at-rule-conditional-no-parentheses");
 
@@ -57,7 +57,7 @@ export default function(primary, _unused, context) {
           }
         }
       } else {
-        if (atrule.params.match(/ ?\(.*\) ?$/)) {
+        if (atrule.params.trim().match(/^\(.*\)$/)) {
           if (context.fix) {
             fix(atrule);
           } else {