Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule: at-rule-no-unknown #127

Merged
merged 3 commits into from Jul 8, 2017
Merged

Add rule: at-rule-no-unknown #127

merged 3 commits into from Jul 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2017

Addresses #86 by adding a "new" rule extending stylelint's at-rule-no-unknown with a built-in list of exceptions including at-rules supported by Sass/SCSS.

@kristerkari
Copy link
Collaborator

Thanks! I'll try to review this as soon as possible

@kristerkari
Copy link
Collaborator

kristerkari commented Jul 8, 2017

I had a look and this seems to add the missing things from @dryoma's pull request.

Would it be possible for you to add the README and CHANGELOG changes from #92? You can simply add a section called HEAD to the change log. I can then merge this and release a new version.

Thanks a lot for your contribution @lithiumlron!

@ghost
Copy link
Author

ghost commented Jul 8, 2017

@kristerkari I've added the changes. Hopefully everything is there.

@kristerkari
Copy link
Collaborator

kristerkari commented Jul 8, 2017

Thanks! Looks good now.

I'm going to cut merge and then release a new version (might not have today since I need to leave soon, but if not then tomorrow).

@kristerkari kristerkari merged commit ef6d565 into stylelint-scss:master Jul 8, 2017
@ghost ghost deleted the at-rule-no-unknown branch July 8, 2017 17:22
@kristerkari
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants