Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies and drop Node.js < 10 support #469

Merged
merged 2 commits into from May 6, 2020
Merged

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented May 6, 2020

@kristerkari feel free to push to this branch before merging to fix the remaining lint issues and ping me. Note that this PR targets the v4 branch.

Non-whitespace diff: https://github.com/kristerkari/stylelint-scss/pull/469/files?w=1

@XhmikosR XhmikosR changed the title Drop node lt 10 Update devDependencies and drop Node.js < 10 support May 6, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

I disabled the jest-setup.js errors. There are only 2 left in /src/utils/__tests__/parseFunctionArguments.js

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@kristerkari
Copy link
Collaborator

I disabled the jest-setup.js errors. There are only 2 left in /src/utils/__tests__/parseFunctionArguments.js

Yeah I can fix the current warnings/errors.

@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

@kristerkari maybe we should not silence the jest/no-standalone-expect errors in jest-setup.js?

Feel free to fix those too. And also, if you want me to cherry pick any of these patches in master let me know. I can rebase this branch before the final merge.

@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

Oh, and also, it would be nice if we could find a way to fix these warnings too :)

You did not set any plugins, parser, or stringifier. Right now, PostCSS does nothing. Pick plugins for your case on https://www.postcss.parts/ and use them in postcss.config.js.

@kristerkari
Copy link
Collaborator

maybe we should not silence the jest/no-standalone-expect errors in jest-setup.js?

I originally took the code from stylelint's repo and did not want to change it, so that's why it's there. I haven't checked if their test runner code has changed since then.

@kristerkari
Copy link
Collaborator

Oh, and also, it would be nice if we could find a way to fix these warnings too

Those tests were missing the parser setting for PostCSS. Fixed now.

@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

I think we could cherry pick a couple of patches like the postcss warnings fix and the missing it block patches. Do you want me to do sherry pick those to master? If so, I'll rebase this branch after that.

@kristerkari
Copy link
Collaborator

Do you want me to do sherry pick those to master? If so, I'll rebase this branch after that.

Please do :)

@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

Done and branches rebased. Just make sure you don't override them.

If you want to release a new patch from master, now it's a good time. Just make sure you do npm i after you switch to master, and then your usual steps.

@kristerkari
Copy link
Collaborator

Alright, I'll publish a patch with the changes in master.

@XhmikosR
Copy link
Member Author

XhmikosR commented May 6, 2020

Added back the node/no-unsupported-features rules with the version set to 10.0.0.

I think we can merge this in the v4-dev branch if you agree.

@XhmikosR XhmikosR marked this pull request as ready for review May 6, 2020 09:40
@@ -11,8 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# switch to `8` when https://github.com/actions/setup-node/issues/27 is fixed
node: [8.16.2, 10, 12, 14]
node: [10, 12, 14]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing @kristerkari: this is the latest 10.x version. The same goes for the package.json engines version. I guess it's OK since we have the ESLint rules in place, but it's your call.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is ok. We shouldn't need to care about minor versions.

@XhmikosR XhmikosR merged commit 13fb890 into v4 May 6, 2020
@XhmikosR XhmikosR deleted the drop-node-lt-10 branch May 6, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants