New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devDependencies and drop Node.js < 10 support #469
Conversation
I disabled the jest-setup.js errors. There are only 2 left in |
Yeah I can fix the current warnings/errors. |
@kristerkari maybe we should not silence the jest/no-standalone-expect errors in jest-setup.js? Feel free to fix those too. And also, if you want me to cherry pick any of these patches in master let me know. I can rebase this branch before the final merge. |
Oh, and also, it would be nice if we could find a way to fix these warnings too :)
|
I originally took the code from stylelint's repo and did not want to change it, so that's why it's there. I haven't checked if their test runner code has changed since then. |
Those tests were missing the |
I think we could cherry pick a couple of patches like the postcss warnings fix and the missing it block patches. Do you want me to do sherry pick those to master? If so, I'll rebase this branch after that. |
Please do :) |
Done and branches rebased. Just make sure you don't override them. If you want to release a new patch from master, now it's a good time. Just make sure you do |
Alright, I'll publish a patch with the changes in master. |
Added back the I think we can merge this in the v4-dev branch if you agree. |
@@ -11,8 +11,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
# switch to `8` when https://github.com/actions/setup-node/issues/27 is fixed | |||
node: [8.16.2, 10, 12, 14] | |||
node: [10, 12, 14] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing @kristerkari: this is the latest 10.x version. The same goes for the package.json engines version. I guess it's OK since we have the ESLint rules in place, but it's your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is ok. We shouldn't need to care about minor versions.
@kristerkari feel free to push to this branch before merging to fix the remaining lint issues and ping me. Note that this PR targets the v4 branch.
Non-whitespace diff: https://github.com/kristerkari/stylelint-scss/pull/469/files?w=1