Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1 Integrate GraphQL ( Migrate from REST to GraphQL ) #49

Closed
KristianWEB opened this issue Nov 1, 2019 · 1 comment
Closed

#1 Integrate GraphQL ( Migrate from REST to GraphQL ) #49

KristianWEB opened this issue Nov 1, 2019 · 1 comment
Assignees

Comments

@KristianWEB
Copy link
Owner

KristianWEB commented Nov 1, 2019

Is your feature request related to a problem? Please describe.
We've decided to migrate our backend architecture from REST API based to GraphQL based since we can handle data better without having to make 120 endpoints. We're starting off with integrating graphql to our existing project using apollo-server-express.

Describe the solution you'd like
For our backend we are gonna use Apollo Server Graphql implementation ( it's got a good ecosystem, more features like advanced caching & better error handling and debugging + there are more people that use which is good )

1. Install packages:

yarn install graphql apollo-server-express --save

Note that we are gonna be using apollo-server-express so we can apply our express code as a middleware and have access to the server core.

2. Integrate graphql with apollo-server-express

Detailed resource on how you do it you can find in here

You will work on this feature by creating and using a branch called feature/apollographql-integration

Pull Request Squashing

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.
  2. If not, then make sure that:

2.1. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

2.2. You have a descriptive commit message with a short title (first line).

2.3. You have only one commit (if not, squash them into one commit).

2.4. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  1. After these steps, you're ready to open a pull request.

3.1. Give a descriptive title to your PR.

3.2. Provide a description of your changes.

3.3. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@KristianWEB KristianWEB self-assigned this Nov 3, 2019
@KristianWEB
Copy link
Owner Author

Implemented base graphql structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant