Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Apollo cache in a more understandable for newcomers way #111

Closed
KristianWEB opened this issue Dec 7, 2019 · 0 comments · Fixed by #123
Closed

Implement Apollo cache in a more understandable for newcomers way #111

KristianWEB opened this issue Dec 7, 2019 · 0 comments · Fixed by #123
Assignees

Comments

@KristianWEB
Copy link
Owner

KristianWEB commented Dec 7, 2019

Is your feature request related to a problem? Please describe.
As you already know we are utilizing Apollo Cache for our local state management. The problem is the way we store/retrieve data is kinda weird and magical so we are gonna make that process easier by implementing some custom methods that are redux likely and more people will understand whats going on.

Describe the solution you'd like
Use this article and Apollo docs to refactor our current apollo cache setup into something more understandable.

You can work on this feature by creating and using a branch called feature/refactor-local-state

Pull Request Squashing

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.
  2. If not, then make sure that:

2.1. You have done your changes in a separate branch. Branches MUST have descriptive names that start with either the fix/ or feature/ prefixes. Good examples are: fix/signin-issue or feature/issue-templates.

2.2. You have a descriptive commit message with a short title (first line).

2.3. You have only one commit (if not, squash them into one commit).

2.4. npm test doesn't throw any error. If it does, fix them first and amend your commit (git commit --amend).

  1. After these steps, you're ready to open a pull request.

3.1. Give a descriptive title to your PR.

3.2. Provide a description of your changes.

3.3. Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant