Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TranslatorInterface instead of Translator class #231

Closed
jvdlaar opened this issue Jun 1, 2016 · 3 comments
Closed

Use TranslatorInterface instead of Translator class #231

jvdlaar opened this issue Jun 1, 2016 · 3 comments
Labels
enhancement

Comments

@jvdlaar
Copy link
Contributor

jvdlaar commented Jun 1, 2016

In the FormHelper class the $translator var is typehinted by the laravel Translator class. But I think it's cleaner to typehint with the interface that theTranslator is implementing, the TranslatorInterface. Then someone is able to implement their own Translator.
@kristijanhusak
Copy link
Owner

Yeah i guess that can be done. You can send a PR, or i'll change it when i catch some time.

@kristijanhusak
Copy link
Owner

I fixed it in the latest version (1.7.10). Thanks for reporting.

@jvdlaar
Copy link
Contributor Author

jvdlaar commented Jun 5, 2016

Oh thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvdlaar @kristijanhusak