Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin-sink lost span #16

Closed
leonly0224 opened this issue Apr 24, 2014 · 2 comments
Closed

zipkin-sink lost span #16

leonly0224 opened this issue Apr 24, 2014 · 2 comments

Comments

@leonly0224
Copy link

the sink lost span while sending them to zipkin collecter

cased by class ZipkinSpanCollectorSink on line 114
while ((event = channel.take()) != null && count < batchSize) {

some events are already taken from the channel even count < batchSize is false
should be changed to
while (count < batchSize && (event = channel.take()) != null) {

@leonly0224 leonly0224 changed the title zipkin-sink lost zipkin-sink lost span Apr 24, 2014
@kristofa
Copy link
Member

Good catch! I'll try to fix this tonight!

@kristofa kristofa self-assigned this Apr 24, 2014
@kristofa
Copy link
Member

Bugfix is checked in. Problem is that there are no unit tests for flume sinks because they are a pain to test because of the inheriting from AbstractSink. But I might add tests later anyway to ensure these kinds of bugs do not recur.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants