Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service appears as "Service A,Service B" #18

Closed
eirslett opened this issue May 20, 2014 · 2 comments
Closed

Service appears as "Service A,Service B" #18

eirslett opened this issue May 20, 2014 · 2 comments

Comments

@eirslett
Copy link
Contributor

See https://groups.google.com/forum/#!topic/zipkin-user/Q_EZp3pQXk4

I believe there's a problem with the design of the Endpoint submitter. Doesn't the service name need to be the same on both the client side and the server side?

@kristofa
Copy link
Member

Hi,

I don't think the problem is with EndPoint submitter.
There was a problem with the rest easy integration code which had different logic for defining span name at client side vs server side.

I added an integration test for it which surfaced the problem and fixed it. I just pushed the change.

Can you try with latest code and see if you still have same issue?

@kristofa
Copy link
Member

Fix merged so I'll close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants